Add install step to create cluster #460
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
December 18, 2024 09:59
DrJosh9000
reviewed
Dec 18, 2024
Co-authored-by: Josh Deprez <[email protected]>
Co-authored-by: Josh Deprez <[email protected]>
jykingston
force-pushed
the
add-install-instructions
branch
from
873b7ff to
c0a4683
Compare
|
I've made those changes, and cleaned up a few mistakes I saw. Would you like to take another look @DrJosh9000? I tried to cleanup my commits but I'm a little rusty, let me know if this PR is still okay! |
DrJosh9000
reviewed
Jan 21, 2025
| @@ -148,7 +273,7 @@ Configuration can also be provided by a config file (`--config` or `CONFIG`), or | |||
|
|
|||
| You can also have an external provider create a secret for you in the namespace before deploying the chart with helm. If the secret is pre-provisioned, replace the `agentToken` and `graphqlToken` arguments with: | |||
|
|
|||
| ```bash | |||
| ```console | |||
There was a problem hiding this comment.
I noticed you changed these from bash or shell to console, but they don't have shell prompts - is there a reason for the change?
Conversely, I think the example console sessions you added should be formatted as console, and include $ prompts before the example commands run (see my last comment).
|
|
||
| ```bash | ||
| ### Deploying K8's stack using Helm |
There was a problem hiding this comment.
As previously (k8s vs k8's):
Suggested change
| ### Deploying K8's stack using Helm | |
| ### Deploying K8s stack using Helm |
Or perhaps:
Suggested change
| ### Deploying K8's stack using Helm | |
| ### Deploying agent-stack-k8s using Helm |
Comment on lines
+108
to
+109
| ``` | ||
| eksctl create cluster --name buildkite-k8-cluster --region ap-southeast-2 --nodegroup-name buildkite-nodes --nodes-min 3 --nodes-max 6 --max-pods-per-node 5 -N 4 |
There was a problem hiding this comment.
Suggested change
| ``` | |
| eksctl create cluster --name buildkite-k8-cluster --region ap-southeast-2 --nodegroup-name buildkite-nodes --nodes-min 3 --nodes-max 6 --max-pods-per-node 5 -N 4 | |
| ```console | |
| $ eksctl create cluster --name buildkite-k8-cluster --region ap-southeast-2 --nodegroup-name buildkite-nodes --nodes-min 3 --nodes-max 6 --max-pods-per-node 5 -N 4 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating the raad me to include full install instructions for deploying the buildkite k8's agent stack to AWS (EKS)
eksctlcommand that would create the EKS Cluster. I found this command in the blog post here and figured it was worth adding; https://buildkite.com/resources/blog/getting-started-with-kubernetes-and-buildkite-a-bubbly-trip-in-the-clouds/