-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Xmas 2022 updates #55
Xmas 2022 updates #55
Conversation
Just a note: I am using test-success.bats and test-failure.bats to show variations in how you can do the BATS test setup and test cases with bats-assert. Trying to demonstrate what's on offer and also a simple way to help people to have something to reference. |
Another note: This upgrade also fixes the dind (docker-in-docker) issue with using the buildkite-plugins/docker-buildkite-plugin with the buildkite/plugin-tester docker image. Example
Would produce this error: This is not related to forgetting to chmod a file or directory or the lack of permissions/access or wrong user. This is caused by an underlying issue with the new system call ( As a result, it has wide-ranging effects on both linux and docker, affected by the underlying dependencies/libraries that are used ( References:
Release Notes Extract:
|
Just another note: These changes have been tested with the following:
Local Testing with
Local Testing with
|
Sorry, looks like I missed a commit for the no faccessat2 bats/bats image. Re-running the tests now. |
Local Testing with
Local Testing with
|
While we are at it, I would also suggest updating |
I'll look into it, lols! 🤣 |
Just for the record, upgraded Looking to revert back from:
Reason: Faced with what looks to be a Docker Buildkit error
Excerpt of Output for Error:
Although |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a very minor comment that may only affect me :P
Thanks a lot for all the effort and hard work
Should be ready for merge, let me know if you have any other changes in mind. :) |
bats-core/bats-assert
fromv0.3.0
tov2.1.0
bats-core/bats-core (bats/bats)
fromv1.7.0
tov1.8.2 (no-faccessat2)
buildkite-plugins/docker-compose
fromv4.5.0
tov4.9.0
buildkite-plugins/bats-mock
fromv2.0.1
tov2.1.0
docker-compose spec
fromv2.0
tov3.7
test.bats
and splitting the tests into:test-success.bats
test-failure.bats
Resolves #56