IVS-228 purepythonparser for critical gherkin checks and info extraction #127
Conversation
|
Should be ready for review with IfcOpenShell/step-file-parser@8a5349f I didn't sync any submodules... so checkout the submodule heads when reviewing |
aothms
changed the title
Ghesselink
temporarily deployed
to
development
GitHub Actions
Inactive
Ghesselink
temporarily deployed
to
development
GitHub Actions
Inactive
There was a problem hiding this comment.
Looking good. Just had to run the step_file_parser as a module to get it running. Along with some changes on the gherkin-side (also see Jira)
Just have to wait a new ifcopenshell build.
| # @nb previously we also checked for: | ||
| # or (len(proc.stderr) > 0): | ||
| # | ||
| # but I now get warnings: | ||
| # | ||
| # - features/environment.py:86: ContextMaskWarning: user code is masking context attribute 'gherkin_outcomes'; | ||
| # see the tutorial for what this means |
There was a problem hiding this comment.
I also noticed this warning a while ago, it appears every run in between scenario's. It seems it is because we set
old_outcomes = getattr(context, 'gherkin_outcomes', [])
context.gherkin_outcomes = old_outcomes
I think it's some leftover from the past, when had issues with context resetting/overlap between scenario's. The lines don't affect the outcomes that are being outputted to the tests or stored in the database. When I remove them, the warning goes away and nothing changes when running pytest or checking the platform.
It's probably safe and clearer to delete them ..
| desc = ifc_file.header.file_description[0][0] | ||
| else: | ||
| desc = ifc_file.header.file_description.description[0] | ||
| # @todo implement based on grammar in header agreement PDF |
There was a problem hiding this comment.
Perhaps this will be covered by IVS-179 / the header policy checks ?
There's at least some overlap.
Doesn't fully work yet. Seems that whitespace within strings is discarded. So MVD and authoring are wrong.