IVS-205 - Limit number of outcomes per rule #120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evandroAlfieri
approved these changes
Nov 11, 2024
aothms
approved these changes
Nov 11, 2024
| @@ -435,6 +438,15 @@ def report(request, id: str): | |||
| "msg": outcome.observed, | |||
| "task_id": outcome.validation_task_public_id | |||
| } | |||
|
|
|||
| key = mapped['attribute'] if 'attribute' in mapped and mapped['attribute'] else 'Uncategorized' | |||
There was a problem hiding this comment.
I had read this several times, can this be abbreviated to:
Suggested change
| key = mapped['attribute'] if 'attribute' in mapped and mapped['attribute'] else 'Uncategorized' | |
| key = mapped.get('attribute', None) or 'Uncategorized' |
| @@ -418,14 +419,16 @@ def report(request, id: str): | |||
| logger.info('Fetching and mapping syntax done.') | |||
|
|
|||
| # retrieve and map schema outcome(s) + instances | |||
| schema_results_count = {} | |||
There was a problem hiding this comment.
Suggested change
| schema_results_count = {} | |
| schema_results_count = defaultdict(int) |
| _type = mapped['constraint_type'] if 'constraint_type' in mapped and mapped['constraint_type'] else 'Uncategorized' | ||
| title = _type.replace('_', ' ').capitalize() + ' - ' + key | ||
| mapped['title'] = title # eg. 'Schema - SegmentStart' | ||
| schema_results_count[title] = schema_results_count[title] + 1 if title in schema_results_count else 1 |
There was a problem hiding this comment.
Suggested change
| schema_results_count[title] = schema_results_count[title] + 1 if title in schema_results_count else 1 | |
| schema_results_count[title] += 1 |
Comment on lines
469
to
471
| 'normative': {}, | ||
| 'prerequisites': {}, | ||
| 'industry': {} |
There was a problem hiding this comment.
Suggested change
| 'normative': {}, | |
| 'prerequisites': {}, | |
| 'industry': {} | |
| 'normative': defaultdict(int), | |
| 'prerequisites': defaultdict(int), | |
| 'industry': defaultdict(int), |
| # TODO: organize this differently? | ||
| key = 'Schema - Version' if label == 'prerequisites' else mapped['feature'] | ||
| mapped['title'] = key | ||
| grouped_gherkin_outcomes_counts[label][key] = grouped_gherkin_outcomes_counts[label][key] + 1 if key in grouped_gherkin_outcomes_counts[label] else 1 |
There was a problem hiding this comment.
Suggested change
| grouped_gherkin_outcomes_counts[label][key] = grouped_gherkin_outcomes_counts[label][key] + 1 if key in grouped_gherkin_outcomes_counts[label] else 1 | |
| grouped_gherkin_outcomes_counts[label][key] = += 1 |
There was a problem hiding this comment.
Minor typo but replaced with += 1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Limit # of outcomes to 10 (configurable) + moved some of grouping/title logic to backend
Example:
