Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update ifcopenshell version for ALS016 fix (IVS-186) #114

Merged
merged 2 commits into from
Nov 5, 2024

Conversation

civilx64
Copy link
Contributor

@civilx64 civilx64 commented Nov 4, 2024

No description provided.

@rw-bsi
Copy link
Contributor

rw-bsi commented Nov 4, 2024

Assigned to Thomas - plus if approved, it requires an update in Docker file of backend too?

https://github.com/buildingSMART/validate/blob/c1c9e48e2633d7a86fbac6d972f03bcd9b0da5b3/docker/backend/Dockerfile#L33C1-L43C2

# install requirements
... 
    # use version of ifcopenshell with desired schema parsing
    # TODO: revert to pyPI when schema parsing is published in the future
    wget -O /tmp/ifcopenshell_python.zip "https://s3.amazonaws.com/ifcopenshell-builds/ifcopenshell-python-311-v0.7.9-c18e4ea-linux64.zip" && \
...

@civilx64
Copy link
Contributor Author

civilx64 commented Nov 4, 2024

Assigned to Thomas - plus if approved, it requires an update in Docker file of backend too?

Yes, Docker needs update also. Thanks for catching that; added in bde4622.

@rw-bsi rw-bsi merged commit cc47387 into development Nov 5, 2024
3 checks passed
@rw-bsi rw-bsi deleted the fix/IVS-186-ALS016 branch November 5, 2024 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants