Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IVS-301 - OJP000 - Object Placement #379

Merged
merged 7 commits into from
Mar 30, 2025
Merged

IVS-301 - OJP000 - Object Placement #379

merged 7 commits into from
Mar 30, 2025
+275 −0

Conversation

Ghesselink
Copy link
Contributor

Very simple rule, verifying the existence of at least one product with a local placement.

We need to add this activation rule because we’re getting strange cases where geometry exists and object placement “doesn’t”, which is against the standard (PlacementForShapeRepresentation WR). It’s not that it doesn’t have placement but simply we have only one rule on OBJ that when not triggered results in a grey card.

@Ghesselink
IVS-301 - OJP000 - Object Placement

Verified

This commit was signed with the committer’s verified signature.
bernhardmgruber Bernhard Manfred Gruber
SSH Key Fingerprint: weZf0SwNJul89Ju5gQHoc2UGb/1VOiLGHWSUTwU/ClQ
Verified
Learn about vigilant mode
Loading
Loading status checks…
7fc0b6c
@Ghesselink
Update description

Verified

This commit was signed with the committer’s verified signature.
bernhardmgruber Bernhard Manfred Gruber
SSH Key Fingerprint: weZf0SwNJul89Ju5gQHoc2UGb/1VOiLGHWSUTwU/ClQ
Verified
Learn about vigilant mode
Loading
Loading status checks…
3aa4cc4
@Ghesselink
Consistency with other activation rules

Verified

This commit was signed with the committer’s verified signature.
bernhardmgruber Bernhard Manfred Gruber
SSH Key Fingerprint: weZf0SwNJul89Ju5gQHoc2UGb/1VOiLGHWSUTwU/ClQ
Verified
Learn about vigilant mode
Loading
Loading status checks…
8696165
Ghesselink and others added 2 commits March 26, 2025 20:56
@Ghesselink @aothms
Update features/rules/OJP/OJP000_Object-placement.feature

Verified

This commit was signed with the committer’s verified signature.
bernhardmgruber Bernhard Manfred Gruber
SSH Key Fingerprint: weZf0SwNJul89Ju5gQHoc2UGb/1VOiLGHWSUTwU/ClQ
Verified
Learn about vigilant mode
Loading
Loading status checks…
620e10a 
Co-authored-by: Thomas Krijnen <[email protected]>
@Ghesselink
rm local placement requirement

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
Loading
Loading status checks…
be09ffc
@Ghesselink Ghesselink mentioned this pull request Mar 26, 2025
Merged
evandroAlfieri
evandroAlfieri requested changes Mar 27, 2025
View reviewed changes
features/rules/OJP/OJP000_Object-placement.feature Outdated
@OJP
@version1
Feature: OJP000 - Object placement
The rule verifies the presence of an object placement to define the overall local coordinate system and placement of the product in space
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Ghesselink please review the descriptions of all 000 rules. They must always, consistently start with "The rule verifies the presence of IFC entities used to..."
cc: @civilx64

@Ghesselink
Description; presence of IFC entities ..
Loading
Loading status checks…
c50bf1e
@Ghesselink
update description
Loading
Loading status checks…
23ea49b
@civilx64 civilx64 merged commit d15140d into development Mar 30, 2025
2 checks passed
@civilx64 civilx64 deleted the IVS-301-OJP000 branch March 30, 2025 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evandroAlfieri evandroAlfieri

@aothms aothms

@civilx64 civilx64

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Ghesselink @aothms @civilx64 @evandroAlfieri