GEM113 no colinear arcs (IVS-303) #335
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Installed mpmath on the validate platform Doing some UAT on the platform, the testfiles behave as expected (checking the header policy checks at the same time) |
Ghesselink
approved these changes
Jan 6, 2025
features/GEM113_Indexed-poly-curve-arcs-must-not-be-defined-using-colinear-points.feature
Outdated
Show resolved
Hide resolved
evandroAlfieri
changed the title
civilx64
reviewed
Jan 9, 2025
|
|
||
| representation_context = geometry.recurrently_get_entity_attr(context, inst, 'IfcRepresentation', 'ContextOfItems') | ||
| precision = mp.mpf(geometry.get_precision_from_contexts(representation_context)) |
There was a problem hiding this comment.
We continue to generate splinters in regards to how geometric precision is handled. It would be nice to consolidate this all in one spot, maybe in sth like /utils/precision.py.
Does not need to be addressed immediately and possibly fits nicely with refactoring in IVS-306.
…ing-colinear-points.feature Co-authored-by: Evandro Alfieri <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Very similar to the face planarity check (but opposite, faces need to be planar, arcs need to be not collinear). Expect conflicts with the two PRs, but just because both add novel stuff in the same place. No functional conflicts.