Fix/IVS-122 - No error handling for non-behave errors in production #322
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
civilx64
reviewed
Nov 5, 2024
features/environment.py
Outdated
| if not 'Behave errors' in context.step.error_message: #exclude behave output from exception logging | ||
| context.caught_exceptions.append(ExceptionSummary.from_context(context)) | ||
| execution_mode = context.config.userdata.get('execution_mode') | ||
| if execution_mode and execution_mode == 'ExecutionMode.TESTING': |
There was a problem hiding this comment.
Suggested change
| if execution_mode and execution_mode == 'ExecutionMode.TESTING': | |
| if execution_mode and execution_mode == ExecutionMode.TESTING: |
ExecutionModel is an enumeration, not a string.
There was a problem hiding this comment.
It originally is, but the behave context stack outputs it as a string.
context.config.userdata.get('execution_mode')
'ExecutionMode.TESTING'
type(context.config.userdata.get('execution_mode'))
<class 'str'>
What we can do is how we solved this earlier in the code, with using eval. That way, the variable is back to it's original enumeration data type.
eval(context.config.userdata.get('execution_mode'))
<ExecutionMode.TESTING: 0>
type(eval(context.config.userdata.get('execution_mode')))
<enum 'ExecutionMode'>
eval(context.config.userdata.get('execution_mode')) == ExecutionMode.TESTING
True
There was a problem hiding this comment.
I also bumped into this from time to time. Just a general recommendation from my side not to use eval().
There was a problem hiding this comment.
Just out of curiosity, why? A reason I can come up with is that it would perhaps be safer to pass data around with the os environment rather than the behave stack.
os.environ["EXECUTION_MODE"] = execution_mode.name
And retrieve it;
execution_mode = ExecutionMode[os.environ.get('EXECUTION_MODE')]
execution_mode == ExecutionMode.TESTING
True
civilx64
approved these changes
Nov 12, 2024
civilx64
deleted the
IVS-112-No_Error_Handling_For_Non-Behave_Errors_in_Production
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.