IVS-198/Fix - IFC102 - Remove enum structural loads #318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ghesselink
added a commit
that referenced
this pull request
Nov 4, 2024
commit e9f4441 Merge: c3dd1a7 afdc400 Author: Scott Lecher <[email protected]> Date: Sat Nov 2 11:37:57 2024 -0400 Merge pull request #300 from buildingSMART/IVS-137-ALB012-IfcAlignmentVerticalSegment.RadiusOfCurvature IVS-137 ALB012 Vertical Segment Radius of Curvature commit afdc400 Author: Geert Hesselink <[email protected]> Date: Fri Nov 1 20:40:47 2024 +0100 append scenario state tuple to list commit c3dd1a7 Author: Geert Hesselink <[email protected]> Date: Fri Nov 1 12:25:31 2024 +0100 IVS-176/VRT000 - Virtual Elements (#313) * IVS-176/VRT000 - Virtual Elements * Update features/VRT000_Virtual-elements.feature Co-authored-by: Evandro Alfieri <[email protected]> * Update features/VRT000_Virtual-elements.feature Co-authored-by: Evandro Alfieri <[email protected]> --------- Co-authored-by: Evandro Alfieri <[email protected]> commit 1ea1652 Author: Geert Hesselink <[email protected]> Date: Thu Oct 31 13:52:44 2024 +0100 IVS-198/Fix - IFC102 - Remove enum structural loads (#318) * IVS-198/Fix - IFC102 - Remove enum structural loads * remove testfile commit 890fd0e Author: Geert Hesselink <[email protected]> Date: Thu Oct 31 09:01:39 2024 +0100 Version update IFC102 for IVS-198 commit fcda725 Merge: e8147db eb2d4d2 Author: Scott Lecher <[email protected]> Date: Wed Oct 30 22:00:15 2024 -0400 Merge pull request #317 from buildingSMART/IVS-198-IFC102-Update IVS-198/Fix - IFC102 Update commit eb2d4d2 Author: Geert Hesselink <[email protected]> Date: Wed Oct 30 23:51:45 2024 +0100 update feature & testfiles commit b01ebb8 Author: Geert Hesselink <[email protected]> Date: Wed Oct 30 23:39:43 2024 +0100 IVS-198/Fix - IFC102 Update commit e8147db Merge: 3c897ed dd77236 Author: Scott Lecher <[email protected]> Date: Tue Oct 29 14:14:25 2024 -0400 Merge pull request #306 from buildingSMART/IVS-53-ALS017-Alignment-vertical-segment-geometric-continuity ALS017 alignment vertical segment geometric continuity (IVS-53) commit 3c897ed Merge: 54d3873 be91e1c Author: Scott Lecher <[email protected]> Date: Tue Oct 29 11:49:29 2024 -0400 Merge pull request #315 from buildingSMART/disableTAS-BRP Disable tas brp commit be91e1c Author: Evandro Alfieri <[email protected]> Date: Tue Oct 29 16:38:42 2024 +0100 Update TAS001_Polygonal-face-boundary-no-self-intersections.feature commit 3c82c4e Author: Evandro Alfieri <[email protected]> Date: Tue Oct 29 16:38:12 2024 +0100 Update BRP001_Polyhedral-IfcFace-boundary-no-self-intersections.feature commit f6fc490 Author: Scott Lecher <[email protected]> Date: Thu Oct 24 11:18:42 2024 -0400 refactor `compare_with_precision()` to use pattern matching (IVS-137) commit c382fe7 Author: Scott Lecher <[email protected]> Date: Wed Oct 23 23:54:52 2024 -0400 avoid NoneTypeError when processing outcomes (IVS-137) commit 54d3873 Merge: 5770408 eeaf1ec Author: Scott Lecher <[email protected]> Date: Wed Oct 23 23:10:27 2024 -0400 Merge pull request #311 from buildingSMART/IVS-181-Fix-SPS007-Exempt-Feature-Elements IVS181/Fix - Exempt feature elements for SPS007 commit d4190bc Merge: 3de923b 5770408 Author: Scott Lecher <[email protected]> Date: Wed Oct 23 22:39:47 2024 -0400 Merge branch 'development' into IVS-137-ALB012-IfcAlignmentVerticalSegment.RadiusOfCurvature commit 3de923b Author: Scott Lecher <[email protected]> Date: Wed Oct 23 22:29:16 2024 -0400 rename test file for ALB012 The test file that raises an exception should start with 'fail'. (IVS-137) commit 6a3c82f Merge: 42959f2 21a5c6f Author: Scott Lecher <[email protected]> Date: Wed Oct 23 20:12:30 2024 -0400 Merge branch 'IVS-181-Fix-Custom-Error-Handling' of https://github.com/buildingSMART/ifc-gherkin-rules into IVS-137-ALB012-IfcAlignmentVerticalSegment.RadiusOfCurvature commit 5770408 Merge: 46f89c5 4fbc4e4 Author: Scott Lecher <[email protected]> Date: Wed Oct 23 20:00:46 2024 -0400 Merge pull request #304 from buildingSMART/ivs165-dont-raise-on-earlier-errors IVS-165 dont raise on earlier errors commit 21a5c6f Author: Geert Hesselink <[email protected]> Date: Wed Oct 23 16:33:52 2024 +0200 Update wording commit eeaf1ec Author: Geert Hesselink <[email protected]> Date: Wed Oct 23 14:00:43 2024 +0200 IVS181/Fix - Exempt feature elements for SPS007 commit d477990 Author: Geert Hesselink <[email protected]> Date: Tue Oct 22 21:46:45 2024 +0200 IVS-181 Fix/Custom Error Handling commit dd77236 Author: Scott Lecher <[email protected]> Date: Fri Oct 18 20:33:55 2024 -0400 add additional fail file for ALS017 This new file is an example of a vertical alignment with changes in vertical gradient without a curve transition. The file fails because the .TransitionCode is set to '.CONSTSAMEGRADIENT.' (IVS-53) commit 0b14c65 Author: Scott Lecher <[email protected]> Date: Thu Oct 17 23:59:12 2024 -0400 finalise ALS017 (IVS-53) commit 4fbc4e4 Author: Geert Hesselink <[email protected]> Date: Thu Oct 17 23:31:07 2024 +0200 display correct scenario & inst id commit 0212ca3 Merge: f9a04f0 c1e2bc5 Author: Scott Lecher <[email protected]> Date: Thu Oct 17 17:28:00 2024 -0400 Merge branch 'development' into IVS-53-ALS017-Alignment-vertical-segment-geometric-continuity commit f415136 Author: Thomas Krijnen <[email protected]> Date: Thu Oct 17 13:16:46 2024 +0200 Don't fail on outcomes raised in earlier scenarios commit 42959f2 Author: Scott Lecher <[email protected]> Date: Sat Oct 12 11:18:24 2024 -0400 add unit test file that raises ZeroDivisionError (IVS-137) commit 515cc49 Author: Scott Lecher <[email protected]> Date: Sat Oct 12 10:48:21 2024 -0400 add explicit relative tolerance for value comparisons (IVS-137) commit 3b6122a Author: Scott Lecher <[email protected]> Date: Sat Oct 12 07:49:22 2024 -0400 (WIP) addresses most of the ALB012 review comments - adds a Given statement for proper entity type of DesignParameters - adds `na` unit test file to confirm this new Given statement - adds `na` unit test file to confirm rule is not activated for alignment with horizontal layout only (IVS-137) commit f5f6237 Author: Scott Lecher <[email protected]> Date: Fri Oct 11 08:12:24 2024 -0400 Update feature file per review comments Co-authored-by: Thomas Krijnen <[email protected]> commit 29922bd Author: Scott Lecher <[email protected]> Date: Thu Oct 10 09:03:31 2024 -0400 finalize ALB012 feature file and unit tests ALB012 focuses solely on 'RadiusOfCurvature' design parameter and includes a scenario that fixes #241. (IVS-137) commit 7f21949 Author: Scott Lecher <[email protected]> Date: Wed Oct 9 21:33:05 2024 -0400 rename ALB011 to ALB012 (IVS-143) commit 50ace43 Merge: 7670846 b89ae45 Author: Scott Lecher <[email protected]> Date: Wed Oct 9 07:53:33 2024 -0400 Merge branch 'IVS-137-ALB011-IfcAlignmentVerticalSegment.RadiusOfCurvature' of https://github.com/fg55b/ifc-gherkin-rules into IVS-137-ALB012-IfcAlignmentVerticalSegment.RadiusOfCurvature commit 7670846 Merge: 9969602 49465b8 Author: Scott Lecher <[email protected]> Date: Tue Oct 8 16:59:26 2024 -0400 Merge branch 'development' into IVS-137-ALB012-IfcAlignmentVerticalSegment.RadiusOfCurvature commit 9969602 Author: Scott Lecher <[email protected]> Date: Wed Oct 2 09:11:12 2024 -0400 rename ALB011 to ALB012 ALB010 is already in use. Renaming this feature will allow for a new rule ALB011 to check RadiusOfCurvature for the horizontal layout. (IVS-137) commit b89ae45 Author: fg55b <[email protected]> Date: Wed Oct 2 08:36:22 2024 -0300 feat/update compare function description commit fc93553 Author: fg55b <[email protected]> Date: Wed Oct 2 08:09:09 2024 -0300 feat/added precision tolerance to the comparison It was created a function of comparison that considers the instance context precision tolerance. This function was added in the 'then' step that compares an attributes to an expression. commit 2e49010 Merge: bc9c3e8 fdd6727 Author: Scott Lecher <[email protected]> Date: Tue Oct 1 14:19:42 2024 -0400 Merge branch 'development' of https://github.com/buildingSMART/ifc-gherkin-rules into IVS-137-ALB011-IfcAlignmentVerticalSegment.RadiusOfCurvature commit f9a04f0 Author: Scott Lecher <[email protected]> Date: Sun Sep 29 17:25:27 2024 -0400 initial WIP commit for ALS017 (IVS-53) commit bc9c3e8 Author: fg55b <[email protected]> Date: Sun Sep 29 13:39:19 2024 -0300 feat/added scenarios and steps Scenarios for validating the horizontal continuity were added. Those scenarios should be implemented in another rule, but were maintained in the commit to be evaluated, and should be altered after commit 9bd31c8 Author: fg55b <[email protected]> Date: Fri Sep 27 00:12:22 2024 -0300 feat/first commit of ALB011 commit 1d2c578 Author: Scott Lecher <[email protected]> Date: Tue Sep 24 10:51:53 2024 -0400 add ALB011 unit test files commit e6b327a Author: Scott Lecher <[email protected]> Date: Tue Sep 10 13:16:16 2024 -0400 align CI version of ifcopenshell with `validate` repo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.