Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply identical scaling for x and y #17

Merged
merged 1 commit into from
Apr 4, 2024

Conversation

thbeu
Copy link
Contributor

@thbeu thbeu commented Apr 3, 2024

Make it obvious that y scaling falls back to x scaling.

@aothms
Copy link
Contributor

aothms commented Apr 3, 2024

Since we have different transform ops, we can also use different variants of non-uniform scaling to better test the compliance in importing applications. What do you think?

@thbeu
Copy link
Contributor Author

thbeu commented Apr 3, 2024

I did not want to change the visual representation of the model. But, indeed, our importing application had an issue with default scaling values.

@aothms aothms merged commit 2933470 into buildingSMART:main Apr 4, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants