-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add readonly #353
Closed
Closed
Add readonly #353
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add contributing information, see https://github.com/buildingSMART/BC…
* Add properties to schema * Add `id` to property, and make property value of type string for easier model binding * Add bool to configure if additional (not specified) properties are allowed * Add properties to property (😀) as discussed in todays call * Add properties to topic PUT and POST models * Add required attributes * Rename property to custom_field * Add info about custom fields to README * Do not allow additional properties flag in extensions * Add id to field definition in extensions * Remove name property of custom field instance in topic * Add description to custom field object * Update README.md * Update README.md --------- Co-authored-by: Georg Dangl <[email protected]>
Co-authored-by: Leonardo Schenkel <[email protected]>
* Optional include topic relations * Update README.md * Update README.md --------- Co-authored-by: Georg Dangl <[email protected]>
* Add contributing information, see buildingSMART/BCF-XML#349 (#277) * BCF v4: Add parent/child relation * Add relation_types extension * Update topic_GET.json * Update topic_GET.json * Include topic relations * c * Add throws information * Update README.md * Update README.md --------- Co-authored-by: Georg Dangl <[email protected]>
* Add audit info to viewpoint * Update README.md * Update README.md * Update README.md
* Add contributing information, see buildingSMART/BCF-XML#349 (#277) * Clarify units of numeric values (#305) * Update README.md * Apply suggestions from code review Co-authored-by: Georg Dangl <[email protected]> Co-authored-by: Georg Dangl <[email protected]> * Fix typo --------- Co-authored-by: Yoram Kulbak <[email protected]>
--------- Co-authored-by: Yoram Kulbak <[email protected]>
* Allow arrays as custom properties * Remove unnecessary sentence * Add custom field example to topic get request * Use object instead of string for enum values definition
* Wrap topic type with object supporting id and name * Update topic_type_GET.json * c * Add status * Add label, priority, stage schemas * Add readme for stage, priority and labels * Add user extension * Fix more * more fixes * Add topic event value wrapper * Update comment event * refactor user * refactor * c * c * Fix event action * Add topic status type * Add id to custom field enumValues * Update README.md * Perhaps * c * c * c
* Add markers * Wrap markers * Add markers to examples * Update README.md * Update README.md
* Add main_viewpoint_guid property to Swagger * Rename property
* Swagger custom fields * Update missing objects * Fix schema errors --------- Co-authored-by: Jon Anders Sollien <[email protected]>
* Add models for translucency * Add endpoint to get translucency
…agger Add topic relations to Swagger spec
Co-authored-by: Georg Dangl <[email protected]>
Co-authored-by: Georg Dangl <[email protected]>
Co-authored-by: Georg Dangl <[email protected]>
Co-authored-by: Georg Dangl <[email protected]>
Co-authored-by: Georg Dangl <[email protected]>
Co-authored-by: Georg Dangl <[email protected]>
Co-authored-by: Georg Dangl <[email protected]>
Co-authored-by: Georg Dangl <[email protected]>
Co-authored-by: Jon Anders Sollien <[email protected]>
Co-authored-by: Jon Anders Sollien <[email protected]>
* Add user_GET model and use it in author fields * Update event action * Add extension related changes to Swagger * Fix errors in Swagger
Done via #354 in the swagger branch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The readOnly flag will determin if certain values can be updated by the end user.
If is done the same way as the "readOnly" flag we have made on custom fields already
#352