-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add docking alternative packages #19
Conversation
oh wait you did, nevermind 👍🏽 |
Looks all good to me, just some minor comments. As a final check before we merge (and after you have closed or fixed my comments) could you post a bdep ci link of the latest commit then? |
Thank for the review! CI: https://ci.stage.build2.org/@39b39ccc-4e24-47e5-9174-f723dea401df |
For Windows Github CI failing, see actions/runner-images#10004 (comment) |
Yes, I think this is the most sensible approach that matches upstream (i.e., they don't seem to have any plans to merge the two branches). Sorry for the delay in replying to this. |
@Rookfighter Windows CI is now fixed on GitHub side, so now we have all tests passing; this is ready to go! 🍻 🎉 |
I'll proceed and merge as @Rookfighter already approved, thanks @wroyca ! |
This follow the approach discussed previously in #15