Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(rust): merge functions for enriching tags #8802

Merged
merged 1 commit into from
Feb 24, 2025

Conversation

Wryhder
Copy link
Contributor

@Wryhder Wryhder commented Feb 16, 2025

Current behavior

Proposed changes

This PR follows up on PR #8707 where I'd asked about combining the functions for enriching the preview and unsafe tags, since they're similar.

I left the enrich_preview_tag() and enrich_unsafe_tag() functions, and just modified their definitions, to avoid breaking code that already references them. But please let me know if I should modify any such code to use enrich_tag() directly.

@adrianbenavides Could you please take a look when you get the chance?

Checks

  • All commits in this Pull Request are signed and Verified by Github.
  • All commits in this Pull Request follow the Ockam commit message convention.
  • There are no Merge commits in this Pull Request. Ockam repo maintains a linear commit history. We merge Pull Requests by rebasing them onto the develop branch. Rebasing to the latest develop branch and force pushing to your Pull Request branch is okay.
  • I have read and accept the Ockam Community Code of Conduct.
  • I have read and accepted the Ockam Contributor License Agreement by adding my Git/Github details in a row at the end of the CONTRIBUTORS.csv file in a separate pull request to the build-trust/ockam repository. The easiest way to do this is to edit the CONTRIBUTORS.csv file in the github web UI and create a separate Pull Request, this will mark the commit as verified.

@Wryhder Wryhder requested a review from a team as a code owner February 16, 2025 21:38
@adrianbenavides
Copy link
Member

Hey @Wryhder thanks for creating the PR 🙏

I'll review it as soon as I can!

Copy link
Member

@adrianbenavides adrianbenavides left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks again @Wryhder! 🚀

@adrianbenavides adrianbenavides added this pull request to the merge queue Feb 24, 2025
Merged via the queue into build-trust:develop with commit 08de461 Feb 24, 2025
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants