feat(rust): node's http server is enabled by default #8603
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adrianbenavides
force-pushed
the
adrian/node-http-server-enabled-by-defauly
branch
4 times, most recently
from
b18181c to
309f55f
Compare
adrianbenavides
force-pushed
the
adrian/node-http-server-enabled-by-defauly
branch
6 times, most recently
from
4a93e66 to
d28bfd5
Compare
adrianbenavides
force-pushed
the
adrian/node-http-server-enabled-by-defauly
branch
from
d28bfd5 to
28a7ba2
Compare
etorreborre
reviewed
Nov 13, 2024
etorreborre
previously approved these changes
Nov 13, 2024
adrianbenavides
force-pushed
the
adrian/node-http-server-enabled-by-defauly
branch
2 times, most recently
from
bb2c2e6 to
0846dfa
Compare
adrianbenavides
force-pushed
the
adrian/node-http-server-enabled-by-defauly
branch
from
0846dfa to
a7466ff
Compare
etorreborre
approved these changes
Nov 14, 2024
adrianbenavides
deleted the
adrian/node-http-server-enabled-by-defauly
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
--http-serverflag is deprecated in favor of--no-healthcheckI also found a flakyness source in the command wherever we use the
find_available_port(and likely in ockam_api). In bats tests, where multiple nodes will run that function at the same time, there can be collisions. That can be fixed by delaying the port assignment until we create the TcpListener. I've created a struct to express the port usage. Here's an example of its usage relevant to this PR.