feat(rust): add one second cache for incoming and outgoing access control #7784
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davide-baldo
force-pushed
the
davide-baldo/one-second-cache
branch
from
8e9c00b to
ccc1175
Compare
davide-baldo
force-pushed
the
davide-baldo/one-second-cache
branch
from
ccc1175 to
2628f31
Compare
adrianbenavides
previously approved these changes
Mar 21, 2024
implementations/rust/ockam/ockam_core/src/access_control/cache.rs
Outdated
Show resolved
Hide resolved
davide-baldo
force-pushed
the
davide-baldo/one-second-cache
branch
from
2628f31 to
703615a
Compare
davide-baldo
force-pushed
the
davide-baldo/one-second-cache
branch
from
703615a to
12307cb
Compare
adrianbenavides
approved these changes
Mar 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ABAC Policy can have a "slow" (few milliseconds) evaluation, adding a cache for 1 second is more than enough to remove any performance penality.
The cache is only available on
stddue to theInstantdependency. I could have usednow()but it wouldn't be as robust.