Fix for nvim 10+ #5
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'd second this request, arduino-language-server for nvim 0.10 really depends on it :) |
|
@cmaglie Any chance I could get a review on this? |
|
Also seconding the request. |
|
would be really nice if this could get merged |
|
Any update on this? |
miracoly
added a commit
to miracoly/.nix-config
that referenced
this pull request
Jan 5, 2025
Currently, this does not work because of an upstream bug in one of arduino-language-server dependencies (bugst/go-lsp#5)
|
I strongly believe this is still an issue, soooo... any news? |
|
Please consider merging this so we don't have to keep using workarounds to make arduino-language-server work 😄 |
alessio-perugini
approved these changes
Mar 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The arduino-language-server depends on this library. However, as of nvim 10.0, the LSP fails to attach to the buffer and it cannot be used.
A simple fix was recommended in the issue above to change the datatype for
jsonrcp.ProgressTokenfromjson.RawMessagetostring. The original datatypejson.RawMessageis itself an alias for a byte array so coercing to a string would just ensure the content is UTF-8 I think. I'm not too familiar with how LSPs work but I think it's reasonable to expect that all data is UTF-8 encoded.Fixes #3.