Skip to content

Commit

Permalink
Corrections
Browse files Browse the repository at this point in the history
  • Loading branch information
Steve Kirkland committed Feb 27, 2025
1 parent dc00f42 commit d8b9d99
Show file tree
Hide file tree
Showing 4 changed files with 9 additions and 10 deletions.
2 changes: 2 additions & 0 deletions lib/maze/client/appium/base_client.rb
Original file line number Diff line number Diff line change
Expand Up @@ -79,6 +79,7 @@ def attempt_start_driver(config)
# Log details of this session
$logger.info "Created Appium session: #{driver.session_id}"
@session_metadata = Maze::Client::Appium::SessionMetadata.new
@session_metadata.id = driver.session_id
@session_metadata.farm = Maze.config.farm.to_s
end
driver
Expand Down Expand Up @@ -168,6 +169,7 @@ def report_session
Bugsnag.notify(error) do |bsg_event|
bsg_event.api_key = ENV['MAZE_APPIUM_BUGSNAG_API_KEY']
metadata = {
'session id': @session_metadata.id,
'success': @session_metadata.success,
'device farm': @session_metadata.farm.to_s,
}
Expand Down
13 changes: 5 additions & 8 deletions lib/maze/client/appium/bb_client.rb
Original file line number Diff line number Diff line change
Expand Up @@ -91,14 +91,11 @@ def log_run_intro
def log_run_outro
api_client = BitBarApiClient.new(Maze.config.access_key)

$logger.info 'Appium session(s) created:'
@session_ids.each do |id|
info = api_client.get_device_session_info(id)
if info
link = Maze::Loggers::LogUtil.linkify(info[:dashboard_link], "BitBar session: #{id}")
$logger.info link
$logger.info "Device used: #{info[:device_name]}"
end
info = api_client.get_device_session_info(@session_metadata.id)
if info
link = Maze::Loggers::LogUtil.linkify(info[:dashboard_link], "BitBar session: #{id}")
$logger.info link
$logger.info "Device used: #{info[:device_name]}"
end
end

Expand Down
3 changes: 1 addition & 2 deletions lib/maze/client/appium/bs_client.rb
Original file line number Diff line number Diff line change
Expand Up @@ -72,8 +72,7 @@ def log_run_intro
end

def log_run_outro
$logger.info 'Appium session(s) created:'
@session_ids.each { |id| $logger.info " #{id}" }
$logger.info "Appium session created: #{@session_metadata.id}"
log_run_intro
end

Expand Down
1 change: 1 addition & 0 deletions lib/maze/client/appium/session_metadata.rb
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ def initialize
@failure_message = 'Default failure message'
end

attr_accessor :id
attr_accessor :farm
attr_accessor :device
attr_accessor :success
Expand Down

0 comments on commit d8b9d99

Please sign in to comment.