Merge pull request #729 from bugsnag/tms/remove-aspecto

Remove Aspecto repeater
bugsnag · Mar 6, 2025 · 401f03f · 401f03f
2 parents b10eb9a + 9867bf8
commit 401f03f
Show file tree

Hide file tree

Showing 11 changed files with 7 additions and 63 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,3 +1,9 @@
+# 9.25.0 - 2025/03/05
+
+## Removals
+
+- Remove Aspecto repeater [729](https://github.com/bugsnag/maze-runner/pull/729)
+
 # 9.24.0 - 2025/03/04
 
 ## Enhancements

diff --git a/bin/maze-runner b/bin/maze-runner
@@ -51,7 +51,6 @@ require_relative '../lib/maze/network'
 require_relative '../lib/maze/proxy'
 require_relative '../lib/maze/retry_handler'
 require_relative '../lib/maze/repeaters/request_repeater'
-require_relative '../lib/maze/repeaters/aspecto_repeater'
 require_relative '../lib/maze/repeaters/bugsnag_repeater'
 require_relative '../lib/maze/runner'
 require_relative '../lib/maze/terminating_server'

diff --git a/docs/Test_Inputs.md b/docs/Test_Inputs.md
@@ -30,7 +30,6 @@ Maze Runner recognises various environment variables, as follows:
 `MAZE_SB_LOCAL` - location of the SmartBear secure tunnel binary.
 `BITBAR_USERNAME`/`BITBAR_ACCESS_KEY` - BitBar account credentials.
 
-`MAZE_ASPECTO_REPEATER_API_KEY` - Enables forwarding of all received POST trace requests to Aspecto, using the API key provided.
 `MAZE_REPEATER_API_KEY` - Enables forwarding of all received session, error and trace requests to Bugsnag, using the API key provided.
 
 #### BrowserStack

diff --git a/lib/maze/configuration.rb b/lib/maze/configuration.rb
@@ -72,9 +72,6 @@ def initialize
     # The server endpoints for which invalid requests should be captured and cause tests to fail
     attr_accessor :captured_invalid_requests
 
-    # API key to use when repeating requests to Bugsnag
-    attr_accessor :aspecto_repeater_api_key
-
     # API key to use when repeating requests to Bugsnag
     attr_accessor :bugsnag_repeater_api_key
 

diff --git a/lib/maze/option.rb b/lib/maze/option.rb
@@ -56,7 +56,6 @@ module Option
 
     # General options
     AWS_PUBLIC_IP = 'aws-public-ip'
-    ASPECTO_REPEATER_API_KEY = 'aspecto-repeater-api-key'
     BUGSNAG_REPEATER_API_KEY = 'repeater-api-key'
     BUGSNAG = 'bugsnag'
     RETRIES = 'retries'

diff --git a/lib/maze/option/parser.rb b/lib/maze/option/parser.rb
@@ -47,11 +47,6 @@ def parse(args)
                 short: :none,
                 default: true
 
-            opt Option::ASPECTO_REPEATER_API_KEY,
-                'Enables forwarding of all received POST requests to Aspecto, using the API key provided.  MAZE_ASPECTO_REPEATER_API_KEY may also be set.',
-                short: :none,
-                type: :string
-
             opt Option::BUGSNAG_REPEATER_API_KEY,
                 'Enables forwarding of all received POST requests to Bugsnag, using the API key provided.  MAZE_REPEATER_API_KEY may also be set.',
                 short: :none,
@@ -281,7 +276,6 @@ def populate_environmental_defaults(options)
             options[Option::SELENIUM_SERVER] ||= ENV['MAZE_SELENIUM_SERVER'] || 'https://us-west-desktop-hub.bitbar.com/wd/hub'
           end
 
-          options[Option::ASPECTO_REPEATER_API_KEY] ||= ENV['MAZE_ASPECTO_REPEATER_API_KEY']
           options[Option::BUGSNAG_REPEATER_API_KEY] ||= ENV['MAZE_REPEATER_API_KEY']
           options[Option::SB_LOCAL] ||= ENV['MAZE_SB_LOCAL'] || '/SBSecureTunnel'
           options[Option::BS_LOCAL] ||= ENV['MAZE_BS_LOCAL'] || '/BrowserStackLocal'

diff --git a/lib/maze/option/processor.rb b/lib/maze/option/processor.rb
@@ -22,8 +22,6 @@ def populate(config, options)
           config.aws_public_ip = options[Maze::Option::AWS_PUBLIC_IP]
           config.enable_retries = options[Maze::Option::RETRIES]
           config.enable_bugsnag = options[Maze::Option::BUGSNAG]
-          aspecto_repeater_api_key = options[Maze::Option::ASPECTO_REPEATER_API_KEY]
-          config.aspecto_repeater_api_key = aspecto_repeater_api_key unless aspecto_repeater_api_key&.empty?
           bugsnag_repeater_api_key = options[Maze::Option::BUGSNAG_REPEATER_API_KEY]
           config.bugsnag_repeater_api_key = bugsnag_repeater_api_key unless bugsnag_repeater_api_key&.empty? 
 

diff --git a/lib/maze/repeaters/aspecto_repeater.rb b/lib/maze/repeaters/aspecto_repeater.rb
diff --git a/lib/maze/servlets/servlet.rb b/lib/maze/servlets/servlet.rb
@@ -39,7 +39,6 @@ def initialize(server, request_type, schema=nil)
         super server
         @request_type = request_type
         @schema = JSONSchemer.schema(schema) unless schema.nil?
-        @aspecto_repeater = Maze::Repeaters::AspectoRepeater.new(@request_type)
         @bugsnag_repeater = Maze::Repeaters::BugsnagRepeater.new(@request_type)
       end
 
@@ -59,7 +58,6 @@ def do_GET(request, _response)
       # @param response [HTTPResponse] The response to return
       def do_POST(request, response)
 
-        @aspecto_repeater.repeat request
         @bugsnag_repeater.repeat request
 
         # Turn the WEBrick HttpRequest into our internal HttpRequest delegate

diff --git a/test/unit/maze/option/parser_test.rb b/test/unit/maze/option/parser_test.rb
@@ -18,7 +18,6 @@ def setup
     ENV.delete('MAZE_SELENIUM_SERVER')
     ENV.delete('MAZE_APPLE_TEAM_ID')
     ENV.delete('MAZE_UDID')
-    ENV.delete('MAZE_ASPECTO_REPEATER_API_KEY')
     ENV.delete('MAZE_REPEATER_API_KEY')
     ENV.delete('BITBAR_USERNAME')
     ENV.delete('BITBAR_ACCESS_KEY')
@@ -136,7 +135,6 @@ def test_environment_values
     ENV['MAZE_SELENIUM_SERVER'] = 'ENV_SELENIUM_SERVER'
     ENV['MAZE_APPLE_TEAM_ID'] = 'ENV_TEAM_ID'
     ENV['MAZE_UDID'] = 'ENV_UDID'
-    ENV['MAZE_ASPECTO_REPEATER_API_KEY'] = 'ENV_ASPECTO_REPEATER_API_KEY'
     ENV['MAZE_REPEATER_API_KEY'] = 'ENV_REPEATER_API_KEY'
 
     args = %w[--farm=bb]
@@ -149,7 +147,6 @@ def test_environment_values
     # Local-only options
     assert_equal('ENV_TEAM_ID', options[Maze::Option::APPLE_TEAM_ID])
     assert_equal('ENV_UDID', options[Maze::Option::UDID])
-    assert_equal('ENV_ASPECTO_REPEATER_API_KEY', options[Maze::Option::ASPECTO_REPEATER_API_KEY])
     assert_equal('ENV_REPEATER_API_KEY', options[Maze::Option::BUGSNAG_REPEATER_API_KEY])
   end
 

diff --git a/test/unit/maze/option/processor_test.rb b/test/unit/maze/option/processor_test.rb
@@ -98,7 +98,6 @@ def test_default_options
     assert_false config.always_log
     assert_false config.https
     assert_nil config.bugsnag_repeater_api_key
-    assert_nil config.aspecto_repeater_api_key
   end
 
   def test_overriden_defaults
@@ -142,38 +141,30 @@ def test_filename_options
   end
 
   def test_repeater_key_responses
-    normal_args = %w[--repeater-api-key=foo --aspecto-repeater-api-key=bar]
+    normal_args = %w[--repeater-api-key=foo]
     normal_options = Maze::Option::Parser.parse normal_args
     normal_config = Maze::Configuration.new
     Maze::Option::Processor.populate normal_config, normal_options
     assert_equal 'foo', normal_config.bugsnag_repeater_api_key
-    assert_equal 'bar', normal_config.aspecto_repeater_api_key
 
     empty_args = %w[--repeater-api-key= --aspecto-repeater-api-key=]
     empty_options = Maze::Option::Parser.parse empty_args
     empty_config = Maze::Configuration.new
     Maze::Option::Processor.populate empty_config, empty_options
     assert_nil empty_config.bugsnag_repeater_api_key
-    assert_nil empty_config.aspecto_repeater_api_key
 
-    ENV['MAZE_ASPECTO_REPEATER_API_KEY'] = 'test_1'
     ENV['MAZE_REPEATER_API_KEY'] = 'test_2'
     env_options = Maze::Option::Parser.parse []
     env_config = Maze::Configuration.new
     Maze::Option::Processor.populate env_config, env_options
-    assert_equal 'test_1', env_config.aspecto_repeater_api_key
     assert_equal 'test_2', env_config.bugsnag_repeater_api_key
-    ENV.delete('MAZE_ASPECTO_REPEATER_API_KEY')
     ENV.delete('MAZE_REPEATER_API_KEY')
 
-    ENV['MAZE_ASPECTO_REPEATER_API_KEY'] = ''
     ENV['MAZE_REPEATER_API_KEY'] = ''
     empty_env_options = Maze::Option::Parser.parse []
     empty_env_config = Maze::Configuration.new
     Maze::Option::Processor.populate empty_env_config, empty_env_options
     assert_nil empty_env_config.bugsnag_repeater_api_key
-    assert_nil empty_env_config.aspecto_repeater_api_key
-    ENV.delete('MAZE_ASPECTO_REPEATER_API_KEY')
     ENV.delete('MAZE_REPEATER_API_KEY')
   end