Skip to content

Commit

Permalink
Merge pull request #668 from bugsnag/tms/deprecated-device
Browse files Browse the repository at this point in the history
Stop using deprecated BrowserStack device iPhone 11 Pro.
twometresteve authored Aug 1, 2024

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
2 parents 0b05e19 + 3f4d0d6 commit 20b5cdd
Showing 8 changed files with 27 additions and 206 deletions.
17 changes: 10 additions & 7 deletions .buildkite/pipeline.yml
Original file line number Diff line number Diff line change
@@ -20,7 +20,9 @@ steps:
timeout_in_minutes: 30
key: android-test-fixture
agents:
queue: 'macos-12-arm'
queue: 'macos-14'
env:
JAVA_VERSION: "17"
command:
- cd bugsnag-android-performance
- make test-fixture
@@ -32,14 +34,14 @@ steps:
timeout_in_minutes: 30
key: ios-test-fixture
agents:
queue: 'macos-12-arm'
queue: 'macos-14'
command:
- cd bugsnag-cocoa
- bundle install
- make test-fixtures
plugins:
artifacts#v1.9.0:
upload: "bugsnag-cocoa/features/fixtures/ios/output/iOSTestApp.ipa"
upload: "bugsnag-cocoa/features/fixtures/ios/output/iOSTestApp_Release.ipa"

- label: ':docker: Build CI image for Ruby 2'
timeout_in_minutes: 30
@@ -240,7 +242,7 @@ steps:
- "push-branch-cli"
plugins:
artifacts#v1.9.0:
download: "bugsnag-cocoa/features/fixtures/ios/output/iOSTestApp.ipa"
download: "bugsnag-cocoa/features/fixtures/ios/output/iOSTestApp_Release.ipa"
upload: "bugsnag-cocoa/maze_output/**/*"
docker-compose#v4.14.0:
pull: appium-test-bs
@@ -250,11 +252,11 @@ steps:
- "./bugsnag-cocoa/features:/app/features"
- "./bugsnag-cocoa/maze_output:/app/maze_output"
command:
- "--app=features/fixtures/ios/output/iOSTestApp.ipa"
- "--app=features/fixtures/ios/output/iOSTestApp_Release.ipa"
- "--farm=bs"
- "--device=IOS_15"
- "--fail-fast"
- "features/barebone_tests.feature"
- "features/release/barebone_tests.feature"
image-repository: 855461928731.dkr.ecr.us-west-1.amazonaws.com/maze-runner
cache-from:
- cli:855461928731.dkr.ecr.us-west-1.amazonaws.com/maze-runner:${BRANCH_NAME}-cli
@@ -344,8 +346,9 @@ steps:
service-ports: true
command:
- "--app=build/test-fixture.apk"
- "--appium-version=1.22"
- "--farm=bb"
- "--device=ANDROID_10|ANDROID_11|ANDROID_12|ANDROID_13"
- "--device=ANDROID_12|ANDROID_13"
- "--fail-fast"
- "--no-tunnel"
- "--aws-public-ip"
8 changes: 7 additions & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,4 +1,10 @@
# # 8.20.2 - 2024/04/03
# 8.20.3 - 2024/08/01

## Removals

- Remove use of deprecated BrowserStack device iPhone 11 Pro [668](https://github.com/bugsnag/maze-runner/pull/668)

# 8.20.2 - 2024/04/03

## Removals

194 changes: 0 additions & 194 deletions Gemfile.lock

This file was deleted.

2 changes: 1 addition & 1 deletion bugsnag-android-performance
2 changes: 1 addition & 1 deletion bugsnag-cocoa
Submodule bugsnag-cocoa updated 407 files
6 changes: 6 additions & 0 deletions bugsnag-maze-runner.gemspec
Original file line number Diff line number Diff line change
@@ -3,6 +3,8 @@ $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
require_relative 'lib/maze'

Gem::Specification.new do |spec|
ruby_version = Gem::Version.new(RUBY_VERSION.dup)

spec.name = 'bugsnag-maze-runner'
spec.version = Maze::VERSION
spec.authors = ['Steve Kirkland']
@@ -17,6 +19,10 @@ Gem::Specification.new do |spec|

spec.executables = spec.files.grep(%r{^bin/[\w\-]+$}) { |f| File.basename(f) }

if ruby_version < Gem::Version.new('3.0.0')
spec.add_dependency 'ffi', '1.16.3'
end

spec.add_dependency 'cucumber', '~> 7.1'
spec.add_dependency 'os', '~> 1.0.0'
spec.add_dependency 'test-unit', '~> 3.5.2'
2 changes: 1 addition & 1 deletion lib/maze.rb
Original file line number Diff line number Diff line change
@@ -7,7 +7,7 @@
# Glues the various parts of MazeRunner together that need to be accessed globally,
# providing an alternative to the proliferation of global variables or singletons.
module Maze
VERSION = '8.20.2'
VERSION = '8.20.3'

class << self
attr_accessor :check, :driver, :internal_hooks, :mode, :start_time, :dynamic_retry, :public_address,
2 changes: 1 addition & 1 deletion lib/maze/client/appium/bs_devices.rb
Original file line number Diff line number Diff line change
@@ -82,7 +82,7 @@ def create_hash
# iOS devices
'IOS_17' => make_ios_hash('iPhone 15', '17'),
'IOS_16' => make_ios_hash('iPhone 14', '16'),
'IOS_15' => make_ios_hash('iPhone 11 Pro', '15'),
'IOS_15' => make_ios_hash('iPhone 13', '15'),
'IOS_14' => make_ios_hash('iPhone 11', '14'),
'IOS_13' => make_ios_hash('iPhone 11', '13'),
'IOS_12' => make_ios_hash('iPhone 8', '12'),

0 comments on commit 20b5cdd

Please sign in to comment.