PLAT-12206 treat discardClasses and redactedKeys as Regex #807
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Build size impact
Generated by 🚫 Danger |
tomlongridge
reviewed
Jun 4, 2024
tomlongridge
reviewed
Jun 5, 2024
tomlongridge
approved these changes
Jun 5, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Change discardClasses and redactedKeys to regex collections.
Keep the fields in the Bugsnag settings window as string collections so that unity and display them, but convert them to Regex when building the config object.
Testing
Added Unit Tests and covered by existing E2E tests