fix for flakes caused by accidental OOM errors reporting during iOS t…

…ests (#805)
bugsnag · May 30, 2024 · 755567f · 755567f
1 parent 7c13017
commit 755567f
Show file tree

Hide file tree

Showing 9 changed files with 5 additions and 30 deletions.
diff --git a/features/fixtures/maze_runner/Assets/Scripts/Scenario.cs b/features/fixtures/maze_runner/Assets/Scripts/Scenario.cs
@@ -38,6 +38,10 @@ public virtual void PrepareConfig(string apiKey, string host)
         Configuration.DotnetScriptingRuntime = FindDotnetScriptingRuntime();
         Configuration.DotnetApiCompatibility = FindDotnetApiCompatibility();
         Configuration.AutoTrackSessions = false;
+        if (Application.platform == RuntimePlatform.IPhonePlayer)
+        {
+            Configuration.EnabledErrorTypes.OOMs = false;
+        }
     }
 
     public void AddSwitchConfigValues(SwitchCacheType switchCacheType, int switchCacheIndex, string switchMountName)

diff --git a/...es/fixtures/maze_runner/Assets/Scripts/Scenarios/Csharp/Persistence/CorruptedCacheFile.cs b/...es/fixtures/maze_runner/Assets/Scripts/Scenarios/Csharp/Persistence/CorruptedCacheFile.cs
@@ -9,10 +9,6 @@ public class CorruptedCacheFile : Scenario
     public override void PrepareConfig(string apiKey, string host)
     {
         base.PrepareConfig(apiKey, host);
-        if (Application.platform == RuntimePlatform.IPhonePlayer)
-        {
-            Configuration.EnabledErrorTypes.OOMs = false;
-        }
     }
 
     public override void Run()

diff --git a/...ures/fixtures/maze_runner/Assets/Scripts/Scenarios/Csharp/Persistence/MaxPersistEvents.cs b/...ures/fixtures/maze_runner/Assets/Scripts/Scenarios/Csharp/Persistence/MaxPersistEvents.cs
@@ -9,10 +9,6 @@ public override void PrepareConfig(string apiKey, string host)
     {
         base.PrepareConfig(apiKey, host);
         Configuration.MaxPersistedEvents = 3;
-        if (Application.platform == RuntimePlatform.IPhonePlayer)
-        {
-            Configuration.EnabledErrorTypes.OOMs = false;
-        }
     }
 
     public override void Run()

diff --git a/features/fixtures/maze_runner/Assets/Scripts/Scenarios/Csharp/Persistence/PersistDeviceId.cs b/features/fixtures/maze_runner/Assets/Scripts/Scenarios/Csharp/Persistence/PersistDeviceId.cs
@@ -5,10 +5,6 @@ public class PersistDeviceId : Scenario
     public override void PrepareConfig(string apiKey, string host)
     {
         base.PrepareConfig(apiKey, host);
-        if (Application.platform == RuntimePlatform.IPhonePlayer)
-        {
-            Configuration.EnabledErrorTypes.OOMs = false;
-        }
     }
 
     public override void Run()

diff --git a/features/fixtures/maze_runner/Assets/Scripts/Scenarios/Csharp/Persistence/PersistEvent.cs b/features/fixtures/maze_runner/Assets/Scripts/Scenarios/Csharp/Persistence/PersistEvent.cs
@@ -6,10 +6,6 @@ public override void PrepareConfig(string apiKey, string host)
     {
         base.PrepareConfig(apiKey, host);
         Configuration.Context = "Error 1";
-        if (Application.platform == RuntimePlatform.IPhonePlayer)
-        {
-            Configuration.EnabledErrorTypes.OOMs = false;
-        }
     }
 
     public override void Run()

diff --git a/...es/fixtures/maze_runner/Assets/Scripts/Scenarios/Csharp/Persistence/PersistEventReport.cs b/...es/fixtures/maze_runner/Assets/Scripts/Scenarios/Csharp/Persistence/PersistEventReport.cs
@@ -6,10 +6,6 @@ public override void PrepareConfig(string apiKey, string host)
     {
         base.PrepareConfig(apiKey, host);
         Configuration.Context = "Error 2";
-        if (Application.platform == RuntimePlatform.IPhonePlayer)
-        {
-            Configuration.EnabledErrorTypes.OOMs = false;
-        }
     }
 
     public override void Run()

diff --git a/...res/maze_runner/Assets/Scripts/Scenarios/Csharp/Persistence/PersistEventReportCallback.cs b/...res/maze_runner/Assets/Scripts/Scenarios/Csharp/Persistence/PersistEventReportCallback.cs
@@ -26,10 +26,6 @@ public override void PrepareConfig(string apiKey, string host)
 
             return true;
         });
-        if (Application.platform == RuntimePlatform.IPhonePlayer)
-        {
-            Configuration.EnabledErrorTypes.OOMs = false;
-        }
     }
 
     public override void Run()

diff --git a/...tures/maze_runner/Assets/Scripts/Scenarios/Csharp/Persistence/ReportMaxPersistedEvents.cs b/...tures/maze_runner/Assets/Scripts/Scenarios/Csharp/Persistence/ReportMaxPersistedEvents.cs
@@ -10,10 +10,6 @@ public override void PrepareConfig(string apiKey, string host)
     {
         _eventsCorrect = CheckForEvents();
         base.PrepareConfig(apiKey, host);
-        if (Application.platform == RuntimePlatform.IPhonePlayer)
-        {
-            Configuration.EnabledErrorTypes.OOMs = false;
-        }
     }
 
     private bool CheckForEvents()

diff --git a/features/ios/ios_native_errors.feature b/features/ios/ios_native_errors.feature
@@ -8,8 +8,7 @@ Feature: iOS Native Errors
     And I wait for 2 seconds
     And On Mobile I relaunch the app
     And I run the game in the "StartSDKDefault" state
-    And I wait to receive an error
-    And the exception "message" equals "The app was likely terminated by the operating system while in the foreground"
+    And I should receive no errors
 
   Scenario: Last Run Info
     When I run the game in the "IosNativeException" state