Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: re-enable danger.js PR comments #2326

Merged
merged 1 commit into from
Feb 14, 2025
Merged

build: re-enable danger.js PR comments #2326

merged 1 commit into from
Feb 14, 2025

Conversation

tomlongridge
Copy link
Contributor

@tomlongridge tomlongridge commented Feb 13, 2025 •
edited
Loading

Goal

Reinstates the GitHub Action permission required for danger.js to write to size diff to the PR.

@github-actions GitHub Actions
Copy link

@bugsnag/browser bundle size diff

Minified Minfied + Gzipped
Before 46.96 kB 14.02 kB
After 46.96 kB 14.02 kB
± No change No change

code coverage diff

<temporarily disabled>

Generated by 🚫 dangerJS against 91df171

@tomlongridge tomlongridge merged commit e35f37f into next Feb 14, 2025
58 checks passed
@tomlongridge tomlongridge deleted the tom/danger-js-perms branch February 14, 2025 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djskinner djskinner djskinner approved these changes

@gingerbenw gingerbenw gingerbenw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tomlongridge @djskinner @gingerbenw