Merge pull request #2316 from bugsnag/plat-12947-5

drop @bugsnag/core/breadcrumb export

.rollup/index.mjs

@@ -39,7 +39,7 @@ function createRollupConfig (options = defaultOptions()) {
         format: 'esm'
       }
     ],
-    external: ['@bugsnag/core'].concat(options.external),
+    external: options.external,
     plugins: [
       replace({
         preventAssignment: true,

packages/browser/src/index-cjs.ts

@@ -1,7 +1,8 @@
 import Client from '@bugsnag/core/client'
 import Event from '@bugsnag/core/event'
 import Session from '@bugsnag/core/session'
-import Breadcrumb from '@bugsnag/core/breadcrumb'
+
+import { Breadcrumb } from '@bugsnag/core'
 
 import assign from '@bugsnag/core/lib/es-utils/assign'
 

packages/browser/src/index-umd.ts

@@ -1,7 +1,8 @@
 import Client from '@bugsnag/core/client'
 import Event from '@bugsnag/core/event'
 import Session from '@bugsnag/core/session'
-import Breadcrumb from '@bugsnag/core/breadcrumb'
+
+import { Breadcrumb } from '@bugsnag/core'
 
 import assign from '@bugsnag/core/lib/es-utils/assign'
 

packages/core/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@bugsnag/core",
-  "main": "src/index.js",
+  "main": "./dist/index.cjs",
   "version": "8.2.0",
   "types": "types/index.d.ts",
   "exports": {
@@ -40,8 +40,7 @@
       "default": "./src/event.js",
       "types": "./src/event.d.ts"
     },
-    "./session": "./src/session.js",
-    "./breadcrumb": "./src/breadcrumb.js"
+    "./session": "./src/session.js"
   },
   "description": "Core classes and utilities for Bugsnag notifiers",
   "homepage": "https://www.bugsnag.com/",

packages/core/rollup.config.npm.mjs

@@ -15,7 +15,7 @@ const plugins = [
 ]
 
 const external = [
-  // '@bugsnag/cuid',
+  '@bugsnag/cuid',
 ]
 
 export default [

packages/core/test/breadcrumb.test.ts

@@ -1,6 +1,6 @@
 import Breadcrumb from '../src/breadcrumb'
 
-describe('@bugsnag/core/breadcrumb', () => {
+describe('Breadcrumb', () => {
   describe('toJSON()', () => {
     it('returns the correct data structure', () => {
       const d = new Date()

packages/core/types/breadcrumb.d.ts

@@ -1,6 +1,7 @@
 import { BreadcrumbType } from './common'
 
 declare class Breadcrumb {
+  public constructor(message: string, metadata: { [key: string]: any }, type: BreadcrumbType, timestamp?: Date)
   public message: string;
   public metadata: { [key: string]: any };
   public type: BreadcrumbType;

packages/delivery-x-domain-request/rollup.config.npm.mjs

@@ -2,5 +2,5 @@ import createRollupConfig from "../../.rollup/index.mjs";
 
 export default createRollupConfig({
   input: "src/delivery.ts",
-  external: ['@bugsnag/core/lib/json-payload']
+  external: ['@bugsnag/core', '@bugsnag/core/lib/json-payload']
 });

packages/delivery-xml-http-request/rollup.config.npm.mjs

@@ -2,5 +2,5 @@ import createRollupConfig from "../../.rollup/index.mjs";
 
 export default createRollupConfig({
   input: "src/delivery.ts",
-  external: ['@bugsnag/core/lib/json-payload']
+  external: ['@bugsnag/core', '@bugsnag/core/lib/json-payload']
 });

packages/electron/src/client/main.js

@@ -2,7 +2,7 @@ const electron = require('electron')
 
 const Client = require('@bugsnag/core/client')
 const Event = require('@bugsnag/core/event')
-const Breadcrumb = require('@bugsnag/core/breadcrumb')
+const { Breadcrumb } = require('@bugsnag/core')
 const Session = require('@bugsnag/core/session')
 const {
   plugin: PluginClientStatePersistence,

packages/electron/src/client/renderer.js

@@ -1,6 +1,6 @@
 const Client = require('@bugsnag/core/client')
 const Event = require('@bugsnag/core/event')
-const Breadcrumb = require('@bugsnag/core/breadcrumb')
+const { Breadcrumb } = require('@bugsnag/core')
 const Session = require('@bugsnag/core/session')
 
 const createClient = require('./createClient')

packages/node/src/index-cjs.ts

@@ -1,7 +1,7 @@
 import Client from '@bugsnag/core/client'
 import Event from '@bugsnag/core/event'
 import Session from '@bugsnag/core/session'
-import Breadcrumb from '@bugsnag/core/breadcrumb'
+import { Breadcrumb } from '@bugsnag/core'
 
 import assign from '@bugsnag/core/lib/es-utils/assign'
 

packages/plugin-app-duration/rollup.config.npm.mjs

@@ -1,5 +1,6 @@
 import createRollupConfig from '../../.rollup/index.mjs'
 
 export default createRollupConfig({
-    input: 'src/app-duration.ts'
+    input: 'src/app-duration.ts',
+    external: ['@bugsnag/core']
 })

packages/plugin-browser-context/rollup.config.npm.mjs

@@ -1,5 +1,6 @@
 import createRollupConfig from "../../.rollup/index.mjs";
 
 export default createRollupConfig({
-  input: "src/context.ts"
+  input: "src/context.ts",
+  external: ["@bugsnag/core"],
 });

packages/plugin-browser-device/rollup.config.npm.mjs

@@ -2,5 +2,5 @@ import createRollupConfig from '../../.rollup/index.mjs'
 
 export default createRollupConfig({
     input: 'src/device.ts',
-    external: ['@bugsnag/cuid'],
+    external: ['@bugsnag/core', '@bugsnag/cuid'],
 })

packages/plugin-browser-request/rollup.config.npm.mjs

@@ -2,5 +2,5 @@ import createRollupConfig from "../../.rollup/index.mjs";
 
 export default createRollupConfig({
   input: "src/request.ts",
-  external: ['@bugsnag/core/lib/es-utils/assign']
+  external: ['@bugsnag/core', '@bugsnag/core/lib/es-utils/assign']
 });

packages/plugin-browser-session/rollup.config.npm.mjs

@@ -2,5 +2,5 @@ import createRollupConfig from "../../.rollup/index.mjs";
 
 export default createRollupConfig({
   input: "src/session.ts",
-  external: ["@bugsnag/core/lib/es-utils/includes"]
+  external: ['@bugsnag/core', "@bugsnag/core/lib/es-utils/includes"]
 });

packages/plugin-client-ip/rollup.config.npm.mjs

@@ -2,5 +2,5 @@ import createRollupConfig from "../../.rollup/index.mjs";
 
 export default createRollupConfig({
   input: "src/client-ip.ts",
-  external: ["@bugsnag/core/lib/es-utils/assign"]
+  external: ['@bugsnag/core', "@bugsnag/core/lib/es-utils/assign"]
 });

packages/plugin-console-breadcrumbs/rollup.config.npm.mjs

@@ -2,5 +2,5 @@ import createRollupConfig from "../../.rollup/index.mjs";
 
 export default createRollupConfig({
   input: "src/console-breadcrumbs.ts",
-  external: ["@bugsnag/core/lib/es-utils/filter", "@bugsnag/core/lib/es-utils/map", "@bugsnag/core/lib/es-utils/reduce"]
+  external: ['@bugsnag/core', "@bugsnag/core/lib/es-utils/filter", "@bugsnag/core/lib/es-utils/map", "@bugsnag/core/lib/es-utils/reduce"]
 });

packages/plugin-electron-app-breadcrumbs/test/app-breadcrumbs.test.ts

@@ -1,4 +1,4 @@
-import Breadcrumb from '@bugsnag/core/breadcrumb'
+import { Breadcrumb } from '@bugsnag/core'
 import Client from '@bugsnag/core/client'
 import { makeApp, makeBrowserWindow } from '@bugsnag/electron-test-helpers'
 import plugin from '../'

packages/plugin-electron-deliver-minidumps/event-serialisation.js

@@ -1,6 +1,6 @@
 const Event = require('@bugsnag/core/event')
 const Session = require('@bugsnag/core/session')
-const Breadcrumb = require('@bugsnag/core/breadcrumb')
+const { Breadcrumb } = require('@bugsnag/core')
 
 const supportedProperties = [
   'app',

packages/plugin-electron-deliver-minidumps/test/minidump-loop.test.ts

@@ -1,6 +1,6 @@
 import EventEmitter from 'events'
 import Session from '@bugsnag/core/session'
-import Breadcrumb from '@bugsnag/core/breadcrumb'
+import { Breadcrumb } from '@bugsnag/core'
 import NetworkStatus from '@bugsnag/electron-network-status'
 import MinidumpDeliveryLoop from '../minidump-loop'
 

packages/plugin-electron-ipc/bugsnag-ipc-main.js

@@ -1,5 +1,5 @@
 const Event = require('@bugsnag/core/event')
-const Breadcrumb = require('@bugsnag/core/breadcrumb')
+const { Breadcrumb } = require('@bugsnag/core')
 const runCallbacks = require('@bugsnag/core/lib/callback-runner')
 const featureFlagDelegate = require('@bugsnag/core/lib/feature-flag-delegate')
 

packages/plugin-electron-ipc/test/bugsnag-ipc-renderer.test.ts

@@ -1,6 +1,6 @@
 import BugsnagIpcRenderer from '../bugsnag-ipc-renderer'
 import { CHANNEL_RENDERER_TO_MAIN, CHANNEL_RENDERER_TO_MAIN_SYNC } from '../lib/constants'
-import Breadcrumb from '@bugsnag/core/breadcrumb'
+import { Breadcrumb } from '@bugsnag/core'
 
 import * as electron from 'electron'
 

packages/plugin-electron-net-breadcrumbs/test/net-breadcrumbs.test-main.ts

@@ -1,4 +1,4 @@
-import Breadcrumb from '@bugsnag/core/breadcrumb'
+import { Breadcrumb } from '@bugsnag/core'
 import { net } from 'electron'
 import { AddressInfo } from 'net'
 import { createServer, STATUS_CODES, Server, IncomingMessage, ServerResponse } from 'http'

packages/plugin-electron-power-monitor-breadcrumbs/test/power-monitor-breadcrumbs.test.ts

@@ -1,7 +1,7 @@
 import { PowerMonitorEvent } from '@bugsnag/electron-test-helpers/src/PowerMonitor'
 import { makePowerMonitor, makeClientForPlugin } from '@bugsnag/electron-test-helpers'
 import plugin from '../'
-import Breadcrumb from '@bugsnag/core/breadcrumb'
+import { Breadcrumb } from '@bugsnag/core'
 
 describe('plugin: electron power monitor breadcrumbs', () => {
   const events: Array<[PowerMonitorEvent, string]> = [

packages/plugin-electron-renderer-event-data/test/renderer-event-data.test.ts

@@ -1,5 +1,5 @@
 import { makeClientForPlugin } from '@bugsnag/electron-test-helpers'
-import Breadcrumb from '@bugsnag/core/breadcrumb'
+import { Breadcrumb } from '@bugsnag/core'
 import plugin from '../'
 
 describe('plugin: electron renderer event data', () => {

packages/plugin-electron-screen-breadcrumbs/test/screen-breadcrumbs.test.ts

@@ -1,4 +1,4 @@
-import Breadcrumb from '@bugsnag/core/breadcrumb'
+import { Breadcrumb } from '@bugsnag/core'
 import { makeClientForPlugin, makeDisplay, makeScreen } from '@bugsnag/electron-test-helpers'
 import plugin from '../'
 

packages/plugin-interaction-breadcrumbs/rollup.config.npm.mjs

@@ -1,5 +1,6 @@
 import createRollupConfig from '../../.rollup/index.mjs'
 
 export default createRollupConfig({
-    input: 'src/interaction-breadcrumbs.ts'
+    input: 'src/interaction-breadcrumbs.ts',
+    external: ['@bugsnag/core']
 })

packages/plugin-interaction-breadcrumbs/test/interaction-breadcrumbs.test.ts

@@ -1,7 +1,6 @@
 import plugin from '../src/interaction-breadcrumbs'
 
-import Client from '@bugsnag/core/client'
-import Breadcrumb from '@bugsnag/core/breadcrumb'
+import { Breadcrumb, Client } from '@bugsnag/core'
 
 const lotsOfWhitespace = ' '.repeat(100000)
 const lotsOfText = 'a'.repeat(100000)
@@ -54,12 +53,10 @@ describe('plugin: interaction breadcrumbs', () => {
     // eslint-disable-next-line @typescript-eslint/no-non-null-assertion
     document.querySelector('button')!.click()
 
-    // TODO: targetSelector should be 'BUTTON.button' but for some reason seems to be ' > HTML:nth-child(2) > BODY:nth-child(2) > DIV > BUTTON.button'
-    // SEE PLAT-12831
     expect(c._breadcrumbs).toStrictEqual([
       new Breadcrumb(
         'UI click',
-        { targetText: 'Click me', targetSelector: expect.stringContaining('BUTTON.button') },
+        { targetText: 'Click me', targetSelector: 'BUTTON.button' },
         'user',
         expect.any(Date)
       )

packages/plugin-navigation-breadcrumbs/rollup.config.npm.mjs

@@ -1,5 +1,6 @@
 import createRollupConfig from '../../.rollup/index.mjs'
 
 export default createRollupConfig({
-    input: 'src/navigation-breadcrumbs.ts'
+    input: 'src/navigation-breadcrumbs.ts',
+    external: ['@bugsnag/core']
 })

packages/plugin-network-breadcrumbs/rollup.config.npm.mjs

@@ -2,5 +2,5 @@ import createRollupConfig from "../../.rollup/index.mjs";
 
 export default createRollupConfig({
   input: "src/network-breadcrumbs.ts",
-  external: ["@bugsnag/core/lib/es-utils/includes"]
+  external: ['@bugsnag/core', "@bugsnag/core/lib/es-utils/includes"]
 });

packages/plugin-simple-throttle/rollup.config.npm.mjs

@@ -2,5 +2,5 @@ import createRollupConfig from '../../.rollup/index.mjs'
 
 export default createRollupConfig({
     input: 'src/throttle.ts',
-    external: ['@bugsnag/core/lib/validators/int-range']
+    external: ['@bugsnag/core', '@bugsnag/core/lib/validators/int-range']
 })

packages/plugin-strip-query-string/rollup.config.npm.mjs

@@ -2,5 +2,5 @@ import createRollupConfig from "../../.rollup/index.mjs";
 
 export default createRollupConfig({
   input: "src/strip-query-string.ts",
-  external: ["@bugsnag/core/lib/es-utils/map", "@bugsnag/core/lib/es-utils/reduce"]
+  external: ['@bugsnag/core', "@bugsnag/core/lib/es-utils/map", "@bugsnag/core/lib/es-utils/reduce"]
 });

packages/plugin-window-onerror/rollup.config.npm.mjs

@@ -1,5 +1,6 @@
 import createRollupConfig from '../../.rollup/index.mjs'
 
 export default createRollupConfig({
-    input: 'src/onerror.ts'
+    input: 'src/onerror.ts',
+    external: ['@bugsnag/core']
 })

packages/plugin-window-unhandled-rejection/rollup.config.npm.mjs

@@ -2,5 +2,5 @@ import createRollupConfig from '../../.rollup/index.mjs'
 
 export default createRollupConfig({
     input: 'src/unhandled-rejection.ts',
-    external: ['@bugsnag/core/lib/iserror', '@bugsnag/core/lib/es-utils/map']
+    external: ['@bugsnag/core', '@bugsnag/core/lib/iserror', '@bugsnag/core/lib/es-utils/map']
 })

packages/react-native/src/notifier.js

@@ -22,7 +22,7 @@ const React = require('react')
 const Client = require('@bugsnag/core/client')
 const Event = require('@bugsnag/core/event')
 const Session = require('@bugsnag/core/session')
-const Breadcrumb = require('@bugsnag/core/breadcrumb')
+const { Breadcrumb } = require('@bugsnag/core')
 
 Event.__type = 'reactnativejs'
 

packages/web-worker/src/index-umd.ts

@@ -1,7 +1,7 @@
 import Client from '@bugsnag/core/client'
 import Event from '@bugsnag/core/event'
 import Session from '@bugsnag/core/session'
-import Breadcrumb from '@bugsnag/core/breadcrumb'
+import { Breadcrumb } from '@bugsnag/core'
 
 import assign from '@bugsnag/core/lib/es-utils/assign'