Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature flags performance improvements #1715

Merged
merged 1 commit into from
Dec 18, 2024

Conversation

robert-smartbear
Copy link
Contributor

Goal

Reduce the time it takes to add a feature flag

Design

Currently feature flags are stored in the same file as metadata which means that each time a feature flag is added, all that data has to be sanitized and saved. By saving the feature flags into separate files we reduce the processing required significantly.

Changeset

Removed the feature flags from metadata object and created a separate file store for them.

Testing

E2E tests

Copy link

github-actions bot commented Dec 11, 2024

Bugsnag.framework binary size increased by 12,992 bytes from 656,120 to 669,112

    FILE SIZE        VM SIZE    
 --------------  -------------- 
  +3.5% +7.22Ki  +3.5% +7.22Ki    __TEXT,__text
  +5.6% +6.39Ki  +5.6% +6.39Ki    String Table
  +4.7% +6.09Ki  +4.7% +6.09Ki    Symbol Table
  +6.9% +2.30Ki  +6.9% +2.30Ki    __DATA,__objc_const
  +3.3%    +608  +3.3%    +608    __TEXT,__objc_stubs
  +3.0%    +579  +3.0%    +579    __TEXT,__objc_methname
  +2.5%    +478  +2.5%    +478    __TEXT,__cstring
  +1.5%    +320  +1.5%    +320    __DATA,__cfstring
  +8.7%    +320  +8.7%    +320    __DATA,__objc_data
  +2.2%    +196  +1.2%    +220    [8 Others]
  +6.5%    +208  +6.5%    +208    __TEXT,__unwind_info
  +3.2%    +152  +3.2%    +152    __DATA,__objc_selrefs
  +6.6%    +152  +6.6%    +152    __TEXT,__gcc_except_tab
   +12%    +132   +12%    +132    __TEXT,__objc_classname
  +7.7%    +120  +7.7%    +120    Rebase Info
  +5.8%    +116  +5.8%    +116    __TEXT,__objc_methtype
  +8.6%     +96  +8.6%     +96    __DATA,__data
  +4.9%     +80  +4.9%     +80    Function Start Addresses
 -34.9% -3.36Ki -21.2% -3.38Ki    [__DATA]
 -32.7% -9.44Ki -32.7% -9.44Ki    [__TEXT]
  [ = ]       0 -83.1% -12.7Ki    [__LINKEDIT]
  +2.0% +12.7Ki  [ = ]       0    TOTAL

Generated by 🚫 Danger

@robert-smartbear robert-smartbear force-pushed the robert/plat-13217_feature_flags_performance branch 10 times, most recently from 852ab8d to 03cd6a5 Compare December 17, 2024 11:40
@robert-smartbear robert-smartbear force-pushed the robert/plat-13217_feature_flags_performance branch from 03cd6a5 to 1b8896a Compare December 17, 2024 12:40
@robert-smartbear robert-smartbear merged commit 4e49777 into next Dec 18, 2024
45 checks passed
@robert-smartbear robert-smartbear deleted the robert/plat-13217_feature_flags_performance branch December 18, 2024 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants