Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build e2e test fixtures with Release configuration #1675

Merged
merged 12 commits into from
Jul 9, 2024

Conversation

twometresteve
Copy link
Contributor

@twometresteve twometresteve commented Jul 5, 2024

Goal

Refactor the e2e test setup to run tests against fixtures built in the Release configuration.

Design

The e2e tests have been run against Debug configuration fixtures for some time for convenience of testing some functionality, but it's more representative overall to run in Release configuration.

This PR refactors the pipeline to run in Release mode and lays the tracks for running in Debug mode, but the actual running of Debug tests will follow in a separate PR.

Changeset

  • All existing feature file moved into features/release
  • Test scenarios with steps that need Debug configuration are duplicated under features/debug
  • Expectations that fail in Release mode (typically due to compile optimisation) are removed from the Release fixture (just the failing steps are removed, the scenarios are still all run).

Some tests are failing on macOS only and I've raised PLAT-12396 to look at those in more depth.

Testing

Covered by a full CI run.

@twometresteve twometresteve requested a review from kstenerud July 5, 2024 12:16
-scheme iOSTestApp \
-workspace iOSTestApp.xcworkspace \
-destination generic/platform=iOS \
-configuration $1 \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could $1 be grabbed at the top of the script and given a name? I've seen too many horror stories when scripts get modified ;-)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a bad idea at all - I'll just change it in my next PR to avoid a conflict.

Copy link

github-actions bot commented Jul 9, 2024

Bugsnag.framework binary size did not change - 656,120 bytes

    FILE SIZE        VM SIZE    
 --------------  -------------- 
  [ = ]       0  [ = ]       0    TOTAL

Generated by 🚫 Danger

@twometresteve twometresteve merged commit 2e1c401 into next Jul 9, 2024
40 checks passed
@twometresteve twometresteve deleted the tms/release-mode branch July 9, 2024 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants