-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build e2e test fixtures with Release configuration #1675
Conversation
[full ci]
[full ci]
-scheme iOSTestApp \ | ||
-workspace iOSTestApp.xcworkspace \ | ||
-destination generic/platform=iOS \ | ||
-configuration $1 \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could $1
be grabbed at the top of the script and given a name? I've seen too many horror stories when scripts get modified ;-)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not a bad idea at all - I'll just change it in my next PR to avoid a conflict.
Generated by 🚫 Danger |
Goal
Refactor the e2e test setup to run tests against fixtures built in the Release configuration.
Design
The e2e tests have been run against Debug configuration fixtures for some time for convenience of testing some functionality, but it's more representative overall to run in Release configuration.
This PR refactors the pipeline to run in Release mode and lays the tracks for running in Debug mode, but the actual running of Debug tests will follow in a separate PR.
Changeset
features/release
features/debug
Some tests are failing on macOS only and I've raised PLAT-12396 to look at those in more depth.
Testing
Covered by a full CI run.