Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configurable limit to the number of attributes that can be added to a span #315

Merged
merged 1 commit into from
Sep 23, 2024

Conversation

kstenerud
Copy link
Contributor

Goal

This is the second half to #314

Copy link

github-actions bot commented Sep 16, 2024

BugsnagPerformance.framework binary size increased by 856 bytes from 481,064 to 481,920

    FILE SIZE        VM SIZE    
 --------------  -------------- 
  +0.5%    +584  +0.5%    +584    __TEXT,__text
  +0.4%    +456  +0.4%    +456    String Table
  +0.4%    +384  +0.4%    +384    Symbol Table
  +2.9%    +209  +2.9%    +209    __TEXT,__cstring
  +1.3%    +192  +1.3%    +192    __DATA,__objc_const
  +1.4%    +181  +1.4%    +181    __TEXT,__objc_methname
  +0.7%     +80  +0.7%     +80    __TEXT,__gcc_except_tab
  +0.4%     +32  +0.4%     +32    __DATA_CONST,__cfstring
  +0.3%     +32  +0.3%     +32    __TEXT,__objc_stubs
  +0.3%     +16  +0.3%     +16    __TEXT,__unwind_info
  +0.7%      +8  +0.7%      +8    Function Start Addresses
  +0.9%      +8  +0.9%      +8    Rebase Info
  +2.6%      +8  +2.6%      +8    __DATA,__objc_ivar
  +0.3%      +8  +0.3%      +8    __DATA,__objc_selrefs
  +0.1%      +3  +0.1%      +3    __TEXT,__objc_methtype
  -1.2%     -32  -1.2%     -32    [__DATA_CONST]
  -1.7%    -208  -1.7%    -208    [__DATA]
  [ = ]       0  -8.2%    -856    [__LINKEDIT]
  -2.6% -1.08Ki  -2.6% -1.08Ki    [__TEXT]
  +0.2%    +856  [ = ]       0    TOTAL

Generated by 🚫 Danger

@kstenerud kstenerud force-pushed the PLAT-12703-atribute-count-limit branch from 8231525 to db0c130 Compare September 16, 2024 14:39
Base automatically changed from PLAT-12703-atribute-limits to next September 18, 2024 15:24
@kstenerud kstenerud force-pushed the PLAT-12703-atribute-count-limit branch from db0c130 to 4892ce5 Compare September 19, 2024 10:53
@kstenerud kstenerud force-pushed the PLAT-12703-atribute-count-limit branch 2 times, most recently from e25fc3a to 28a5bf5 Compare September 19, 2024 12:14
@kstenerud kstenerud force-pushed the PLAT-12703-atribute-count-limit branch from 28a5bf5 to 12c3773 Compare September 23, 2024 07:24
@kstenerud kstenerud merged commit 5932db0 into next Sep 23, 2024
24 checks passed
@kstenerud kstenerud deleted the PLAT-12703-atribute-count-limit branch September 23, 2024 08:31
@kstenerud kstenerud mentioned this pull request Sep 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants