Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PLAT-10357] Move global appVersion, appVersionCode and appBundleVersion to sub commands #41

Merged
merged 11 commits into from
Jun 29, 2023
Merged

[PLAT-10357] Move global appVersion, appVersionCode and appBundleVersion to sub commands #41

merged 11 commits into from
Jun 29, 2023

Conversation

joshedney
Copy link
Contributor

@joshedney joshedney commented Jun 29, 2023 •
edited
Loading

Goal

Move global flags:

  • appVersion to version
  • appVersionCode to versionCode
  • appBundleVersion to bundleVersion

in the create-build and upload dart sub commands

Correct buildUUID name in server requests for Android Proguard

Get values from Android AAB manifest via resource ID

Design

This approach matches the pattern used in all new sub commands.

Testing

  • Android Proguard - Tested manually
Screenshot 2023-06-29 at 10 33 32

@joshedney joshedney self-assigned this Jun 29, 2023
lemnik
lemnik approved these changes Jun 29, 2023
View reviewed changes
Copy link
Contributor

@lemnik lemnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

tomlongridge
tomlongridge reviewed Jun 29, 2023
View reviewed changes
pkg/utils/upload-options.go Show resolved Hide resolved
pkg/build/create.go Outdated Show resolved Hide resolved
@joshedney joshedney merged commit a0e8883 into next Jun 29, 2023
@joshedney joshedney deleted the je/plat-10357-remove-global-app-flags branch June 29, 2023 15:09
@joshedney joshedney mentioned this pull request Jun 29, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomlongridge tomlongridge tomlongridge approved these changes

@lemnik lemnik lemnik approved these changes

Assignees

@joshedney joshedney

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@joshedney @lemnik @tomlongridge