Merge pull request #52 from bugcrowd/checkstyle-more-tolerant

Make Checkstyle formatter more tolerant of missing attributes
bugcrowd · May 30, 2019 · 282fe77 · 282fe77
2 parents 3d04fa2 + 58dd882
commit 282fe77
Show file tree

Hide file tree

Showing 3 changed files with 15 additions and 7 deletions.
diff --git a/lib/test_summary_buildkite_plugin/input.rb b/lib/test_summary_buildkite_plugin/input.rb
@@ -237,11 +237,11 @@ def file_contents_to_failures(str)
       end
 
       def summary(filename, error)
-        severity = error.attribute('severity').value
-        line = error.attribute('line').value
-        column = error.attribute('column').value
-        location = "#{filename}:#{line}:#{column}"
-        message = error.attribute('message').value
+        severity = error.attribute('severity')&.value
+        line = error.attribute('line')&.value
+        column = error.attribute('column')&.value
+        location = [filename, line, column].compact.join(':')
+        message = error.attribute('message')&.value
 
         "[#{severity}] #{location}: #{message}"
       end

diff --git a/spec/sample_artifacts/checkstyle.xml b/spec/sample_artifacts/checkstyle.xml
@@ -2,5 +2,7 @@
 <checkstyle version="8.0">
 	<file name="src/main/java/io/timnew/sol/Sol.kt">
 		<error line="106" column="1" severity="error" message="Needless blank line(s)" source="no-consecutive-blank-lines" />
+		<error line="109" severity="error" message="Without column" source="no-consecutive-blank-lines" />
+		<error severity="error" message="Without column or line" source="no-consecutive-blank-lines" />
 	</file>
 </checkstyle>
diff --git a/spec/test_summary_buildkite_plugin/input_spec.rb b/spec/test_summary_buildkite_plugin/input_spec.rb
@@ -220,13 +220,19 @@
     it { is_expected.to be_a(TestSummaryBuildkitePlugin::Input::Checkstyle) }
 
     it 'has all failures' do
-      expect(input.failures.count).to eq(1)
+      expect(input.failures.count).to eq(3)
     end
 
     it 'failures have summary' do
-      expect(input.failures.first.summary).to eq(
+      expect(input.failures[0].summary).to eq(
+        '[error] src/main/java/io/timnew/sol/Sol.kt: Without column or line'
+      )
+      expect(input.failures[1].summary).to eq(
         '[error] src/main/java/io/timnew/sol/Sol.kt:106:1: Needless blank line(s)'
       )
+      expect(input.failures[2].summary).to eq(
+        '[error] src/main/java/io/timnew/sol/Sol.kt:109: Without column'
+      )
     end
 
     it 'failures have details' do