Skip to content

Commit

Permalink
Add macOS testing to CI (#57)
Browse files Browse the repository at this point in the history
Platform coverage in CI is valuable for C++ since the toolchains are so
variable. This PR should ensure nobody accidentally breaks macOS
support.

Windows does not currently work due to cel-cpp issues. I don't think we
can put any priority on patching that right now. I think MSVC testing
would go a long way to attest that changes are more properly portable,
versus GCC and Clang which are fairly similar. Hopefully, we can
eventually rectify this. The necessary workflow change is already
present in this PR, so once `cel-cpp` is fixed we just need to add
`windows-latest` to the matrix. Some day.

This PR is one I worked on a long time ago, but got stalled on. I
rebased it and cleaned it up since I think it is valuable enough to
merge.
  • Loading branch information
jchadwick-buf authored Jul 24, 2024
1 parent 66834e0 commit 5ba3f45
Showing 1 changed file with 7 additions and 1 deletion.
8 changes: 7 additions & 1 deletion .github/workflows/ci.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,11 @@ permissions:
contents: read
jobs:
test:
strategy:
matrix:
os: [ubuntu-latest, macos-latest]
name: Unit tests
runs-on: ubuntu-latest
runs-on: ${{ matrix.os }}
steps:
- name: Cache
uses: actions/cache@v3
Expand All @@ -24,6 +27,9 @@ jobs:
uses: actions/checkout@v4
with:
fetch-depth: 1
- name: Install Make
run: choco install make
if: runner.os == 'Windows'
- name: Install go
uses: actions/setup-go@v5
with:
Expand Down

0 comments on commit 5ba3f45

Please sign in to comment.