Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support many declarative protovalidate rules #29

Merged
merged 8 commits into from
Jan 24, 2025
Merged

Conversation

Alfus
Copy link
Contributor

@Alfus Alfus commented Dec 29, 2024

JSONSchema supports a subset of the protovalidate rules. This PR converts protovalidate rules into the associated JSONSchema rules.

@Alfus Alfus requested a review from mfridman December 29, 2024 15:44
@Alfus Alfus requested a review from rodaine January 2, 2025 14:38
@Alfus Alfus requested a review from jchadwick-buf January 16, 2025 18:40
Copy link
Member

@jchadwick-buf jchadwick-buf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a pretty big PR and I haven't really had a chance to comb over every detail, but in general this LGTM.

@Alfus Alfus merged commit b9d2586 into main Jan 24, 2025
4 checks passed
@Alfus Alfus deleted the alfus/validate branch January 24, 2025 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants