Update bazel and deps #1111
Open
Update bazel and deps #1111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This modernizes the bazel setup to support 7.x, still using the WORKSPACE
keith
force-pushed
the
ks/update-bazel-and-deps
branch
from
261e913
to
984c7b5
Compare
keith
commented
May 24, 2024
|
|
||
| # gazelle:repository_macro dependencies.bzl%go_third_party | ||
| go_third_party() | ||
| pinned_maven_install() |
There was a problem hiding this comment.
this is still a bit of a mess since you cannot do some of these loads in the same bzl file where you pull in the dep, I think we'd have to create another file if we wanted to eliminate all the custom things done here.
| name = "pgv_pip_deps", | ||
| requirements = "@com_envoyproxy_protoc_gen_validate//python:requirements.in", | ||
| requirements_lock = "@com_envoyproxy_protoc_gen_validate//python:requirements.txt", |
There was a problem hiding this comment.
the old rule was removed the new one requires a lockfile
| go_third_party() | ||
|
|
||
| maven_install( | ||
| artifacts = PROTOBUF_MAVEN_ARTIFACTS, |
There was a problem hiding this comment.
this is required for protobuf java code now
| @@ -238,4 +238,5 @@ java_proto_gen_validate = rule( | |||
| "srcjar": "lib%{name}-src.jar", | |||
| }, | |||
| implementation = _java_proto_gen_validate_impl, | |||
| toolchains = ["@bazel_tools//tools/jdk:toolchain_type"], | |||
There was a problem hiding this comment.
| @@ -35,9 +35,5 @@ cc_test( | |||
|
|
|||
| py_proto_library( | |||
| name = "bar_py_proto", | |||
| srcs = ["bar.proto"], | |||
| deps = [ | |||
There was a problem hiding this comment.
py_proto_library from rules_python now works how all the others do
| @@ -9,7 +9,7 @@ public final class RequiredValidation { | |||
| private RequiredValidation() { | |||
| } | |||
|
|
|||
| public static void required(String field, GeneratedMessageV3 value) throws ValidationException { | |||
| "requirements.in", | ||
| "setup.cfg", | ||
| ]) | ||
|
|
||
| compile_pip_requirements( |
There was a problem hiding this comment.
this also creates a test to make sure the lockfile is updated, so the new lockfile is slightly easier to manage with that
Draft
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This modernizes the bazel setup to support 7.x, still using the WORKSPACE