Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update protoc and query-es plugins #1252

Merged
merged 4 commits into from
May 24, 2024
Merged

Update protoc and query-es plugins #1252

merged 4 commits into from
May 24, 2024

Conversation

app-token-plugins[bot]
Copy link
Contributor

New plugin versions found. Please review.

@pkwarren pkwarren changed the title Found new plugin versions Update protoc and query-es plugins May 24, 2024
FROM gcr.io/distroless/cc-debian12:latest@sha256:e1065a1d58800a7294f74e67c32ec4146d09d6cbe471c1fa7ed456b2d2bf06e0 AS base

FROM scratch
COPY --link --from=base / /
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated plugins to squash layers.

"@connectrpc/protoc-gen-connect-query": "1.4.1"
},
"devDependencies": {
"esbuild": "^0.21.3"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For node plugins using esbuild, I'd like to figure out how to keep these dependencies upgraded.

requires_python: ">=3.8"
deps:
# https://pypi.org/project/protobuf/
- "protobuf~=5.27"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another manual step for now is keeping this updated.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you remind me, did we have a list/checklist of the manual things we didn't automate? I.e., the python stuff, the java publishing, etc.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mainly just the Python requirements.txt upgrades and I guess now these two (esbuild, python deps in buf.plugin.yaml).

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe worth updating a readme or creating a known issue to remind ourselves. So when we come back to this we at least have something to reference (and also update as we add more automation over time).

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#1199 for python, at least.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added #1254 and #1255 to track the manual upgrades here.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@pkwarren pkwarren merged commit 9d9f5b6 into main May 24, 2024
4 checks passed
@pkwarren pkwarren deleted the fetch-versions branch May 24, 2024 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants