Add testcase

bufbuild · Jan 15, 2025 · 37c005f · 37c005f
1 parent 419c1c0
commit 37c005f
Show file tree

Hide file tree

Showing 5 changed files with 21 additions and 3 deletions.
diff --git a/make/go/dep_protoc.mk b/make/go/dep_protoc.mk
@@ -10,9 +10,9 @@ $(call _assert_var,CACHE_INCLUDE)
 $(call _assert_var,CACHE_BIN)
 
 # Settable
-# https://github.com/protocolbuffers/protobuf/releases 20241204 checked 20241217
+# https://github.com/protocolbuffers/protobuf/releases 20250108 checked 20250115
 # NOTE: Set to version compatible with genproto source code (only used in tests).
-PROTOC_VERSION ?= 29.1
+PROTOC_VERSION ?= 29.3
 
 # Google adds a dash to release candidate versions in the name of the
 # release artifact, i.e. v27.0-rc1 -> v27.0-rc-1

diff --git a/private/bufpkg/bufcheck/lint_test.go b/private/bufpkg/bufcheck/lint_test.go
@@ -1270,6 +1270,15 @@ func TestRunLintCustomWasmPlugins(t *testing.T) {
 	)
 }
 
+func TestRunLintEditionsGoFeatures(t *testing.T) {
+	t.Parallel()
+	testLint(
+		t,
+		"editions_go_features",
+		bufanalysistesting.NewFileAnnotationNoLocation(t, "a.proto", "PACKAGE_DEFINED"),
+	)
+}
+
 func testLint(
 	t *testing.T,
 	relDirPath string,

diff --git a/private/bufpkg/bufcheck/testdata/lint/editions_go_features/a.proto b/private/bufpkg/bufcheck/testdata/lint/editions_go_features/a.proto
@@ -0,0 +1,5 @@
+edition = "2023";
+
+import "google/protobuf/go_features.proto";
+
+option features.(pb.go).api_level = API_OPAQUE;
diff --git a/private/bufpkg/bufcheck/testdata/lint/editions_go_features/buf.yaml b/private/bufpkg/bufcheck/testdata/lint/editions_go_features/buf.yaml
@@ -0,0 +1,4 @@
+version: v1
+lint:
+  use:
+    - PACKAGE_DEFINED
diff --git a/private/gen/data/datawkt/datawkt.gen.go b/private/gen/data/datawkt/datawkt.gen.go