Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Messages: add support for paginating thread messages #503

Merged
merged 4 commits into from
May 4, 2024

Conversation

renatonascalves
Copy link
Member

@renatonascalves renatonascalves commented Apr 21, 2024

Initially, at #429, we added support for message pagination while listing threads. In this pr, we add support when getting a single thread, and its messages.

fixes #409
Ticket: https://buddypress.trac.wordpress.org/ticket/9146

@renatonascalves renatonascalves merged commit 7c8d07b into master May 4, 2024
8 checks passed
@renatonascalves renatonascalves deleted the feature/fix-409-thread-messages branch May 4, 2024 13:29
@berzki
Copy link

berzki commented May 15, 2024

Hi all,

I apologise for adding my comment here, but I am unable to create a Trac ticket for this enhancement. But I felt I should submit my feedback/request somehow. Paging was added to private messages in version 14 for the REST API here which is awesome. Are we able to get paging for private message threads in the web version too? As the whole thread is loaded as one page, threads with hundreds of messages have loading delays and put a lot of strain on resources. Another thing to note is that when you are in active conversation with others, the page will need to be refreshed to see the new messages. This is fine but adds to the overall load as the thread gets larger and the need to scroll all the way to the bottom to see the new messages (quite time consuming on a mobile phone).

If I ask nicely, do you think we could get this in version 14 if it's not too much trouble? It is certainly a much-needed feature. :)

Lastly, thanks to all for continuously providing new features for the community to use!

@renatonascalves
Copy link
Member Author

@berzki Thanks! This is something we discussed internally a while ago. I created a ticket so that we can handle it soon: https://buddypress.trac.wordpress.org/ticket/9156

@berzki
Copy link

berzki commented May 16, 2024

Thanks for this @renatonascalves! I hope this will be for both the Legacy (which is what I am using) and the Nouveau template? I've never used the Nouveau template, so I don't know much about how it works. I apologise if I misunderstood the ticket! Lol. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Private messages pagination
2 participants