Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PROD-8020 - Platform > Accessibility Issues in Platform #4516

Open
wants to merge 6 commits into
base: release
Choose a base branch
from
Open

PROD-8020 - Platform > Accessibility Issues in Platform #4516

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
e8b2be0
[PROD-8020] Add group cover image alt text
amincdev Sep 20, 2024
0553c46
[PROD-8020] Add aria-label to Profile header more options button
amincdev Sep 24, 2024
9a421db
[PROD-8020] Add aria-label to group header more options button
amincdev Sep 24, 2024
7906315
[PROD-8020] Add aria-label for formatting button
amincdev Sep 24, 2024
fa869ee
[PROD-8020] Add aria-label to photos open link
amincdev Oct 23, 2024
57e0b49
[PROD-8020] Add aria-label to videos open in theater link
amincdev Oct 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/bp-forums/templates/default/bbpress/form-attachments.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,7 +153,7 @@

<?php if ( bp_is_active( 'media' ) && bbp_use_wp_editor() ) : ?>
<div class="post-elements-buttons-item show-toolbar" data-bp-tooltip-pos="down-left" data-bp-tooltip="<?php esc_attr_e( 'Show formatting', 'buddyboss' ); ?>" data-bp-tooltip-hide="<?php esc_html_e( 'Hide formatting', 'buddyboss' ); ?>" data-bp-tooltip-show="<?php esc_html_e( 'Show formatting', 'buddyboss' ); ?>">
<a href="#" id="show-toolbar-button" class="toolbar-button bp-tooltip">
<a href="#" id="show-toolbar-button" class="toolbar-button bp-tooltip" aria-label="<?php esc_attr_e( 'Show formatting', 'buddyboss' ); ?>">
<span class="bb-icon-l bb-icon-font"></span>
</a>
</div>
Expand Down
2 changes: 1 addition & 1 deletion src/bp-forums/templates/default/bbpress/form-forum-attachments.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@
if ( bp_is_active( 'media' ) ) :
?>
<div class="post-elements-buttons-item show-toolbar" data-bp-tooltip-pos="down-left" data-bp-tooltip="<?php esc_attr_e( 'Show formatting', 'buddyboss' ); ?>" data-bp-tooltip-hide="<?php esc_html_e( 'Hide formatting', 'buddyboss' ); ?>" data-bp-tooltip-show="<?php esc_html_e( 'Show formatting', 'buddyboss' ); ?>">
<a href="#" id="show-toolbar-button" class="toolbar-button bp-tooltip">
<a href="#" id="show-toolbar-button" class="toolbar-button bp-tooltip" aria-label="<?php esc_attr_e( 'Show formatting', 'buddyboss' ); ?>">
<span class="bb-icon-l bb-icon-font"></span>
</a>
</div>
Expand Down
2 changes: 1 addition & 1 deletion ...-templates/bp-nouveau/buddypress/common/js-templates/activity/parts/bp-editor-toolbar.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
?>
<script type="text/html" id="tmpl-editor-toolbar">
<div class="post-elements-buttons-item show-toolbar" data-bp-tooltip-pos="up" data-bp-tooltip="<?php esc_attr_e( 'Show formatting', 'buddyboss' ); ?>" data-bp-tooltip-hide="<?php esc_html_e( 'Hide formatting', 'buddyboss' ); ?>" data-bp-tooltip-show="<?php esc_attr_e( 'Show formatting', 'buddyboss' ); ?>">
<a href="#" id="show-toolbar-button" class="toolbar-button bp-tooltip">
<a href="#" id="show-toolbar-button" class="toolbar-button bp-tooltip" aria-label="<?php esc_attr_e( 'Show formatting', 'buddyboss' ); ?>">
<span class="bb-icon-l bb-icon-font"></span>
</a>
</div>
Expand Down
2 changes: 1 addition & 1 deletion ...-nouveau/buddypress/common/js-templates/messages/parts/bp-messages-formatting-toolbar.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
<?php if ( bp_is_active( 'media' ) ) : ?>

<div class="post-elements-buttons-item show-toolbar" data-bp-tooltip-pos="down-left" data-bp-tooltip="<?php esc_attr_e( 'Show formatting', 'buddyboss' ); ?>" data-bp-tooltip-hide="<?php esc_attr_e( 'Hide formatting', 'buddyboss' ); ?>" data-bp-tooltip-show="<?php esc_attr_e( 'Show formatting', 'buddyboss' ); ?>">
<a href="#" id="show-toolbar-button" class="toolbar-button bp-tooltip">
<a href="#" id="show-toolbar-button" class="toolbar-button bp-tooltip" aria-label="<?php esc_attr_e( 'Show formatting', 'buddyboss' ); ?>">
<span class="bb-icon-l bb-icon-font"></span>
</a>
</div>
Expand Down
2 changes: 1 addition & 1 deletion src/bp-templates/bp-nouveau/buddypress/groups/groups-loop.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@
<div class="bs-group-cover only-grid-view <?php echo esc_attr( $has_default_cover . ' cover-' . $group_cover_height ); ?>">
<a href="<?php bp_group_permalink(); ?>">
<?php if ( ! empty( $group_cover_image_url ) ) { ?>
<img src="<?php echo esc_url( $group_cover_image_url ); ?>">
<img src="<?php echo esc_url( $group_cover_image_url ); ?>" alt="<?php esc_attr_e( 'Group cover image', 'buddyboss' ); ?>">
<?php } ?>
</a>
</div>
Expand Down
2 changes: 1 addition & 1 deletion src/bp-templates/bp-nouveau/buddypress/groups/single/messages/private-message.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -277,7 +277,7 @@
">
<?php if ( $is_media_active ) : ?>
<div class="post-elements-buttons-item show-toolbar" data-bp-tooltip-pos="down-left" data-bp-tooltip="<?php esc_attr_e( 'Show formatting', 'buddyboss' ); ?>" data-bp-tooltip-show="<?php esc_html_e( 'Show formatting', 'buddyboss' ); ?>" data-bp-tooltip-hide="<?php esc_html_e( 'Hide formatting', 'buddyboss' ); ?>">
<a href="#" id="show-toolbar-button" class="toolbar-button bp-tooltip">
<a href="#" id="show-toolbar-button" class="toolbar-button bp-tooltip" aria-label="<?php esc_attr_e( 'Show formatting', 'buddyboss' ); ?>">
<span class="bb-icon-l bb-icon-font"></span>
</a>
</div>
Expand Down
2 changes: 1 addition & 1 deletion src/bp-templates/bp-nouveau/buddypress/groups/single/messages/public-message.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -191,7 +191,7 @@
">
<?php if ( $is_media_active ) : ?>
<div class="post-elements-buttons-item show-toolbar" data-bp-tooltip-pos="down-left" data-bp-tooltip="<?php esc_attr_e( 'Show formatting', 'buddyboss' ); ?>" data-bp-tooltip-show="<?php esc_html_e( 'Show formatting', 'buddyboss' ); ?>" data-bp-tooltip-hide="<?php esc_html_e( 'Hide formatting', 'buddyboss' ); ?>">
<a href="#" id="show-toolbar-button" class="toolbar-button bp-tooltip">
<a href="#" id="show-toolbar-button" class="toolbar-button bp-tooltip" aria-label="<?php esc_attr_e( 'Show formatting', 'buddyboss' ); ?>">
<span class="bb-icon-l bb-icon-font"></span>
</a>
</div>
Expand Down
1 change: 1 addition & 0 deletions src/bp-templates/bp-nouveau/buddypress/media/entry.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -307,6 +307,7 @@ class="bb-open-media-theatre bb-photo-cover-wrap bb-item-cover-wrap"
data-group-id="<?php echo esc_attr( $group_id ); ?>"
data-attachment-id="<?php echo esc_attr( $attachment_id ); ?>"
data-can-edit="<?php echo esc_attr( bp_media_user_can_edit( $bp_media_id ) ); ?>"
aria-label="<?php esc_attr_e( 'Open image in media theatre', 'buddyboss' ); ?>"
href="#">
<img src="<?php echo esc_url( buddypress()->plugin_url ); ?>bp-templates/bp-nouveau/images/placeholder.png" data-src="<?php bb_media_photos_directory_image_thumbnail(); ?>" alt="<?php bp_media_title(); ?>" class="lazy"/>
</a>
Expand Down
1 change: 1 addition & 0 deletions src/bp-templates/bp-nouveau/buddypress/video/entry.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,6 +144,7 @@ class="bb-open-video-theatre bb-video-cover-wrap bb-item-cover-wrap"
data-album-id="<?php bp_video_album_id(); ?>"
data-group-id="<?php bp_video_group_id(); ?>"
data-attachment-id="<?php echo esc_attr( $attachment_id ); ?>"
aria-label="<?php esc_attr_e( 'Open video in media theatre', 'buddyboss' ); ?>"
href="#">
<img src="<?php echo esc_url( buddypress()->plugin_url ); ?>bp-templates/bp-nouveau/images/video-placeholder.jpg" data-src="<?php echo esc_url( $poster_full ); ?>" alt="<?php bp_video_title(); ?>" class="lazy"/>
</a>
Expand Down
2 changes: 1 addition & 1 deletion src/bp-templates/bp-nouveau/includes/groups/template-tags.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -556,7 +556,7 @@ function bb_nouveau_group_header_bubble_buttons( $args = array() ) {
bp_get_template_part( 'common/more-options-view' );
$template_part_content = ob_get_clean();

$output = sprintf( '<a href="#" class="bb_more_options_action"><i class="bb-icon-f bb-icon-ellipsis-h"></i></a><div class="bb_more_options_list bb_more_dropdown"> %1$s %2$s</div><div class="bb_more_dropdown_overlay"></div>', $template_part_content, $output );
$output = sprintf( '<a href="#" class="bb_more_options_action" aria-label="%1$s"><i class="bb-icon-f bb-icon-ellipsis-h"></i></a><div class="bb_more_options_list bb_more_dropdown"> %2$s %3$s</div><div class="bb_more_dropdown_overlay"></div>', esc_attr__( 'More Options', 'buddyboss' ), $template_part_content, $output );

bp_nouveau_wrapper( array_merge( $args, array( 'output' => $output ) ) );
}
Expand Down
2 changes: 1 addition & 1 deletion src/bp-templates/bp-nouveau/includes/members/template-tags.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -221,7 +221,7 @@ function bp_nouveau_member_header_bubble_buttons( $args = array() ) {
bp_get_template_part( 'common/more-options-view' );
$template_part_content = ob_get_clean();

$output = sprintf( '<a href="#" class="bb_more_options_action"><i class="bb-icon-f bb-icon-ellipsis-h"></i></a><div class="bb_more_options_list bb_more_dropdown"> %1$s %2$s</div><div class="bb_more_dropdown_overlay"></div>', $template_part_content, $output );
$output = sprintf( '<a href="#" class="bb_more_options_action" aria-label="%1$s"><i class="bb-icon-f bb-icon-ellipsis-h"></i></a><div class="bb_more_options_list bb_more_dropdown"> %2$s %3$s</div><div class="bb_more_dropdown_overlay"></div>', esc_attr__( 'More Options', 'buddyboss' ), $template_part_content, $output );

bp_nouveau_wrapper( array_merge( $args, array( 'output' => $output ) ) );
}
Expand Down