PROD-7928 #4504
Merged
PROD-7928 #4504
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* release: (41 commits) Update: Grunt Update: Grunt string-replace Update: Version name update Update: Language file update grunt Added change log PROD-7988 - pull the API changes PROD-7744 - Update - DB server version instead of server/host PROD-7976 - phpcbf PROD-7976 remove duplicate code logic PROD-7976 Update normalizer code logic PROD-7976 Update normalizer code logic PROD-7933 - Remove welcome videos [PROD-7872] Update mutual connections list styling PROD-7517 - Fixed - If disable all CPT with WP post, then display error PROD-7818 - Split search word and search within title and content for forum, topic and reply PROD-7818 - Fixed - search result inconsistency when search any word within html for topic and reply PROD-7818 - Fixed - search result inconsistency when search any word within html PROD-7517 - Update doc block comment PROD-7860 - Add condition to check activity empty or not ...
jitendrabanjara1991
requested changes
Sep 20, 2024
| @@ -673,20 +673,45 @@ function bp_ps_anyfield_search( $f ) { | |||
|
|
|||
| } | |||
|
|
|||
| if ( in_array( $filter, array( 'contains', 'like' ) ) ) { | |||
There was a problem hiding this comment.
Suggested change
| if ( in_array( $filter, array( 'contains', 'like' ) ) ) { | |
| if ( in_array( $filter, array( 'contains', 'like' ), true ) ) { |
Comment on lines
683
to
690
| if ( 'like' === $filter ) { | ||
| $term = str_replace( '\\\\%', '\\%', $term ); | ||
| $term = str_replace( '\\\\_', '\\_', $term ); | ||
| $query_placeholder[] = '%' . $term . '%'; | ||
| } else { | ||
| $query_placeholder[] = '%' . bp_ps_esc_like( $term ) . '%'; | ||
| } | ||
|
|
There was a problem hiding this comment.
Suggested change
| if ( 'like' === $filter ) { | |
| $term = str_replace( '\\\\%', '\\%', $term ); | |
| $term = str_replace( '\\\\_', '\\_', $term ); | |
| $query_placeholder[] = '%' . $term . '%'; | |
| } else { | |
| $query_placeholder[] = '%' . bp_ps_esc_like( $term ) . '%'; | |
| } | |
| if ( 'like' === $filter ) { | |
| $term = str_replace( '\\\\%', '\\%', $term ); | |
| $term = str_replace( '\\\\_', '\\_', $term ); | |
| $query_placeholder[] = '%' . $term . '%'; | |
| } else { | |
| $query_placeholder[] = '%' . bp_ps_esc_like( $term ) . '%'; | |
| } | |
| @@ -673,20 +673,45 @@ function bp_ps_anyfield_search( $f ) { | |||
|
|
|||
| } | |||
|
|
|||
| if ( in_array( $filter, array( 'contains', 'like' ) ) ) { | |||
| $every_word_clauses = array(); | |||
| $query_placeholder = array(); | |||
There was a problem hiding this comment.
$query_placeholder = array();
Move this variable before if ( in_array( $filter, array( 'contains', 'like' ) ) ) { this condition
- Replaced hardcoded query placeholders with dynamic array handling. - Updated `$wpdb->prepare()` to use spread operator for `$query_placeholder`. - Improved readability by separating `$every_word_clauses` and `$query_placeholder` initialization.
jitendrabanjara1991
approved these changes
Sep 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira Issue:
https://buddyboss.atlassian.net/browse/PROD-7928
General Note
Keep all conversations related to this PR in the associated Jira issue(s). Do NOT add comment on this PR or edit this PR’s description.
Notes to Developer
Notes to Reviewer