This repository has been archived by the owner on Jun 5, 2019. It is now read-only.
Search #50
Open
Search #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MongoDB search is pretty meh. This branch is the first stab at leveraging Elasticsearch. More about Elasticsearch here: http://www.elasticsearch.org Experiment adds `query` and `search` params to Entry#findByParams (supported in both templates and REST API). `query` defers to Elasticsearch's "simple query string" (better for filtering/templates), while `search` uses a "fuzzy" query with some simple defaults (better for autocomplete). Ended up using query for the typeahead anyway (adding a * to the end by default). Add Entry#fetchWithParams and typeahead.js to frontend, and a quick demo to the dashboard. Issues: * Currently setting query or search will override and ignore all other params sent in. If people like this approach, we should port the function altogether to rely on Elasticsearch. (would be pretty straight-forward)
Still uses a timeout though :/ just want to try on Travis
Conflicts: server/routes/api/entries.coffee
Start to fill in Buckets route tests a bit
(and start a "prep" which waits for Mongo connection)
davidkaneda
force-pushed
the
search
branch
2 times, most recently
from
3220fdc
to
d8df8b5
Compare
Discussed Model#refresh with mongoosastic contrib. Unfortunately still requires a timeout after initial indexing/refresh. Adds more tests.
Conflicts: client/source/templates/entries/row.hbs server/models/bucket.coffee server/models/entry.coffee server/routes/api/buckets.coffee server/routes/api/entries.coffee test/reset.coffee test/server/models/bucket.coffee
Conflicts: server/routes/api/entries.coffee
Conflicts: client/source/views/entries/browser.coffee package.json user/templates/index.hbs
Conflicts: test/reset.coffee test/server/models/entry.coffee test/server/routes/api/buckets.coffee
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MongoDB search is pretty meh. This branch is the first stab at leveraging Elasticsearch.
Experiment adds
queryandsearchparams to Entry#findByParams (supported in both templates and REST API).querydefers to Elasticsearch's "simple query string" (better for filtering/templates), whilesearchuses a "fuzzy" query with some simple defaults (better for autocomplete). Ended up using query for the typeahead anyway (adding a * to the end by default). Also adds Entry#fetchWithParams and typeahead.js to frontend, and a quick demo to the dashboard.To do: