Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update 17.9.0 #682

Merged
merged 5 commits into from
Aug 25, 2024
Merged

update 17.9.0 #682

merged 5 commits into from
Aug 25, 2024

Conversation

FoseFx
Copy link
Member

@FoseFx FoseFx commented Aug 25, 2024 •
edited
Loading

See #668

Changes

  • rebase to 17.9.0

Checklist

  • My change builds
  • I tested my change
  • I use the "bttv_" prefix for all resources I propose
  • When adding a string I also added it to the bttv.Res.strings Enum and res/values/strings.xml (in mod) and res/values/public.xml (in disass)
  • If my change is significant enough, I added it to the CHANGELOG.md under master
  • I'll add myself and everyone else who contributed to this change to the contributors list using all-contributors
  • I license my changes according to the MIT License.

@FoseFx FoseFx merged commit b72a813 into master Aug 25, 2024
3 checks passed
@FoseFx FoseFx deleted the update-17.9.0 branch August 25, 2024 16:28
@Zerwin
Copy link
Contributor

Zerwin commented Aug 26, 2024

@FoseFx Seems like login broke with the update to 17.9.0. It was still working with 17.0.

@FoseFx FoseFx mentioned this pull request Aug 26, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@FoseFx @Zerwin