add impl of op_ctv #2143
Open
add impl of op_ctv #2143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ben2077
force-pushed
the
covenants-op-ctv
branch
from
6800292
to
8533d51
Compare
ben2077
force-pushed
the
covenants-op-ctv
branch
from
8533d51
to
1a969c7
Compare
sputn1ck
reviewed
Mar 26, 2024
| } | ||
|
|
||
| for _, txOut := range vm.tx.TxOut { | ||
| outputs.Write(txOut.PkScript) |
There was a problem hiding this comment.
I might not understand something, but aren't we missing commiting to the output values?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a simple CTV implementation based on my understanding of CTV. Regarding the implementation of TxHash, the current OP_TxHash and OP_CHECKTXHASHVERIFY have been well implemented in #2078.