Fix typos on signature.go #2065
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 7024494115
💛 - Coveralls |
guggero
reviewed
Nov 28, 2023
| @@ -124,8 +124,7 @@ func schnorrVerify(sig *Signature, hash []byte, pubKeyBytes []byte) error { | |||
| // 7. Fail if is_infinite(R) | |||
| // 8. Fail if not hash_even_y(R) | |||
| // 9. Fail is x(R) != r. | |||
| // 10. Return success iff not failure occured before reachign this | |||
| // point. | |||
| // 10. Return success if failure did not occur before reaching this point. | |||
There was a problem hiding this comment.
The term iff is a scientific notation for "if and only if". So this is now wrong and not in line with the actual BIP: https://github.com/bitcoin/bips/blob/master/bip-0340.mediawiki#verification
There was a problem hiding this comment.
Damn, I missed that because the original line was not at all correct English.
There was a problem hiding this comment.
An iff mixed in with the rest of the typos was indistinguishable from another type :)
Anyway, if you PR putting the iff back I'll merge. If not, I'll PR tomorrow.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes typos in the documentation.