-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
wire: add method TxID to MsgTx #2055
Conversation
Pull Request Test Coverage Report for Build 8419979356Details
💛 - Coveralls |
I am aware of This PR makes it clear what |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's ok to have a method that returns a string directly.
But there's no need for all this code to do so.
8abe213
to
c4526f7
Compare
@yyforyongyu for your review |
This commit adds a method to MsgTx called TxID. This method returns the transaction ID (txid) of the subject transaction.
This commit adds a method to MsgTx called TxID. This method returns the transaction ID (txid) of the subject transaction. This commit also adds a function for deriving the transaction ID from the double hash of the transaction.