Sort accounts internally by their account number. #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When enumerated, accounts are now returned in increasing order by their account number. Fixes btcsuite#23.
|
I really don't like this at all. If want to sort accounts we should do it by account name. Account number is internal to the app and honestly I don't even think we should display it. |
|
This had to do with the internal ordering of accounts, not necessarily what is presented in the view. It was needed for consistency and efficiency. This is the Bitcoin repo, but the Decred Paymetheus already contains this change. I disagree that account numbers should be invisible to the user, since they determine what keys are derived from the seed and it allows for some additional compatibility with other BIP0044 wallets or key derivation tools. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When enumerated, accounts are now returned in increasing order by
their account number.
Fixes #23.