Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update email regex #166

Merged
merged 26 commits into from
Apr 22, 2024
Merged

update email regex #166

merged 26 commits into from
Apr 22, 2024

Conversation

Prabalpsingh7115
Copy link
Contributor

@Prabalpsingh7115 Prabalpsingh7115 commented Apr 17, 2024

Overview

  1. This PR does the following
    a- The regex filter for institute email id was only checking for the substring "@iiitdmj.ac.in" which is now replaced and
    checking if the email id is ending with the above substring.
    b- Fixed a bug where user can go to Signin and Signup page by url even if he/she is logged in.
    c- Added a validation for phone number.

Essential Checklist

  • The PR title starts with "Fix #bugnum: ", followed by a short, clear summary of the changes. (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • "Allow edits from maintainers" is checked. (See here for instructions on how to enable it.)
  • The PR is made from a branch that's not called "main/master".

Copy link

netlify bot commented Apr 17, 2024

Deploy Preview for merch-site ready!

Name Link
🔨 Latest commit 8a579a6
🔍 Latest deploy log https://app.netlify.com/sites/merch-site/deploys/661fdb3ec48f780009e1f515
😎 Deploy Preview https://deploy-preview-166--merch-site.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Priyansh61
Copy link
Collaborator

@Prabalpsingh7115 kindly update the PR description?

@Priyansh61
Copy link
Collaborator

@Prabalpsingh7115 Please update the PR

@Prabalpsingh7115
Copy link
Contributor Author

@Priyansh61 I have updated the description. Kindly review the PR .

@Priyansh61 Priyansh61 merged commit 40aaf55 into bsoc-bitbyte:main Apr 22, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants