This repository has been archived by the owner on Jun 16, 2023. It is now read-only.
Adding support for OVHcloud and tlschallenge #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
My apologies, I somehow managed to overlook this PR for an embarrassingly long time. I see the new files you've added are swapping out the Traefik certificate resolver configuration. I appreciate it and this is useful information for anyone wishing to use Traefik in a different configuration, but I'm concerned about adding code which looks "ready to run" but which I won't be testing. What do you think about contributing a new markdown file which talks about how to make these changes? It could include your changes, plus link to the Traefik docs maybe? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added docker-compose.yml files for OVHcloud and tlschallenge certificate resolvers. I just wanted to share them with you. Thank you for your work. That is exactly what I was looking for.