Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify Tensor struct #98

Closed
wants to merge 5 commits into from
Closed

Simplify Tensor struct #98

wants to merge 5 commits into from

Conversation

mofeing
Copy link
Member

@mofeing mofeing commented Sep 26, 2023

Closes #89

Copy link
Member

@jofrevalles jofrevalles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good to me!

@codecov
Copy link

codecov bot commented Sep 26, 2023

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (49d32d9) 80.29% compared to head (dac9c68) 80.41%.
Report is 5 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #98      +/-   ##
==========================================
+ Coverage   80.29%   80.41%   +0.11%     
==========================================
  Files          14       14              
  Lines         934      909      -25     
==========================================
- Hits          750      731      -19     
+ Misses        184      178       -6     
Files Coverage Δ
ext/TenetChainRulesCoreExt.jl 86.36% <100.00%> (ø)
ext/TenetMakieExt.jl 100.00% <100.00%> (ø)
ext/TenetQuacExt.jl 86.95% <100.00%> (ø)
src/Quantum/MP.jl 90.00% <100.00%> (+0.86%) ⬆️
src/Quantum/Quantum.jl 74.19% <ø> (+0.45%) ⬆️
src/Tenet.jl 100.00% <ø> (ø)
src/Tensor.jl 88.99% <100.00%> (+0.01%) ⬆️
src/Transformations.jl 97.50% <100.00%> (ø)
src/Quantum/PEP.jl 0.00% <0.00%> (ø)
src/Numerics.jl 88.70% <33.33%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mofeing
Copy link
Member Author

mofeing commented Sep 26, 2023

Funk, this PR is more merging in master.

@mofeing mofeing closed this Sep 26, 2023
@mofeing mofeing deleted the fix/despecialize-tensor branch September 26, 2023 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Despecialize Tensor struct and methods to decrease compilation time
2 participants