Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import code from Tensors package #81

Merged
merged 19 commits into from
Aug 29, 2023
Merged

Import code from Tensors package #81

merged 19 commits into from
Aug 29, 2023

Conversation

mofeing
Copy link
Member

@mofeing mofeing commented Aug 21, 2023

As explained in bsc-quantic/EinExprs.jl#24, using Tensors may be a burden for external users, specifically the ones that interoperate several TN packages.

Proposal is to cut any dependency to Tensors and import that code to Tenet.

I'm also bumping the minimum Julia version to 1.9, since it's stable enough, v1.10 is near, all of our users are using v1.9 and it makes package extensions easier to maintain.

@mofeing mofeing added the enhancement New feature or request label Aug 21, 2023
@mofeing mofeing self-assigned this Aug 21, 2023
@codecov
Copy link

codecov bot commented Aug 21, 2023

Codecov Report

Merging #81 (5d6ebda) into master (c78bb60) will decrease coverage by 77.60%.
Report is 9 commits behind head on master.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master     #81       +/-   ##
==========================================
- Coverage   77.82%   0.22%   -77.60%     
==========================================
  Files           9      11        +2     
  Lines         699     885      +186     
==========================================
- Hits          544       2      -542     
- Misses        155     883      +728     
Files Changed Coverage Δ
ext/TenetMakieExt.jl 0.00% <0.00%> (-100.00%) ⬇️
ext/TenetQuacExt.jl 0.00% <ø> (-86.96%) ⬇️
src/Helpers.jl 2.94% <0.00%> (-74.48%) ⬇️
src/Numerics.jl 0.00% <0.00%> (ø)
src/Quantum/MP.jl 0.00% <0.00%> (-89.89%) ⬇️
src/Quantum/PEP.jl 0.00% <0.00%> (ø)
src/Quantum/Quantum.jl 0.00% <0.00%> (-73.74%) ⬇️
src/Tenet.jl 100.00% <ø> (ø)
src/Tensor.jl 0.00% <0.00%> (ø)
src/TensorNetwork.jl 0.00% <0.00%> (-83.74%) ⬇️
... and 1 more

@mofeing mofeing merged commit 6a67594 into master Aug 29, 2023
2 of 3 checks passed
@mofeing mofeing deleted the refactor/include-tensor branch August 29, 2023 15:25
@mofeing mofeing added this to the 0.3 milestone Aug 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant