Merge developments in preparation for release v0.4 #121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Remove `meta` field from `Tensor` * Refactor type of `Tensor.inds` field to `ImmutableVector` Reduce inference-time overhead due to `Tuple` specializations * Avoid `TensorNetwork` specialization on `Makie.plot` methods * Fix annotation of hyperindices on `plot` * Fix hyperindex labelling
Semantics were not very clear. Use `length(tensors(tn))` instead.
`copy` is not acting as expected and the copied TN has the `.indices` field mutated.
Move "class" to dual `TensorNetwork`/`AbstractTensorNetwork` types. Closes Consider a `Classes.jl` fork or build same functionality on top of other packages #108
…#120) * Encode `TensorNetwork` graph using a incidence matrix * Optimize time, memory of `TensorNetwork` constructor * Fix `SparseArrays.findnz` on `IncidenceMatrix` * Replace `Bijections` for `BijectiveDicts` * Replace `IncidenceMatrix` for dictionaries * Refactor code and tests * Fix `Makie` code * Refactor `ChainRulesTestUtils.rand_tangent` to new `TensorNetwork` fields * Refactor `ChainRulesCore` rules to new `TensorNetwork` fields * Fix order of `tensors` when extracting them from `IdDict` Elements of an `AbstractDict` have no guarantee to be in any order. This was affecting the order in which the `tensors` method was returning the tensors, and thus, doing weird things when computing the jacobian. * Relax `Vector` eltype specialization in `rand_tangent` * Fix Makie code to new `tensors(tn)` order * Fix order stability of elements in `arrays`
to TensorNetwork
`smooth_annotation` function for code correctness
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #121 +/- ##
==========================================
+ Coverage 80.73% 88.18% +7.45%
==========================================
Files 14 10 -4
Lines 929 584 -345
==========================================
- Hits 750 515 -235
+ Misses 179 69 -110
☔ View full report in Codecov by Sentry. |
jofrevalles
reviewed
Nov 13, 2023
* Implement LinearAlgebra.lu decompoisition * Add tests for the new LinearAlgebra.lu function * Replace legacy labels for inds function * Refactor LU decomposition * Fix undef var in `factorinds` * Refactor QR decomposition * Update docstrings of `qr`,`lu` * Refactor SVD factorization * Fix typo * Add factorizations to docs --------- Co-authored-by: Sergio Sánchez Ramírez <[email protected]>
jofrevalles
approved these changes
Nov 13, 2023
Todorbsc
approved these changes
Nov 13, 2023
There was a problem hiding this comment.
Everything seems nice to me. The only improvements I could comment (and I think they are not necessary) are:
- Solve the CI / Documentation (push) Github Action error (link)
- Add tests for some methods to increase the code coverage percentage
Yeah, I'm not sure why this is happening but it should be solved when merging to master.
Actually, this PR increases "global" coverage by a 8%. And it's approaching a 90% which is high. |
Prepare for upgradable stdlibs of Julia 1.10
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.