-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactored the website into jekyll #9
Conversation
some minor issues with scrolling
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just few things that came in quick look.
README.md
Outdated
- if you have thumbnails for your pictures, put them inside img/timg folder with the same name as original image folder. | ||
- insert necesary metadata in _data/gallery.yml file | ||
|
||
(please note that if you don't have any thumbnails folder, you have to specify that in .yml by assigning empty string to thumbFolder variable i.e. `thumbFolder: ""` ) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we skip this step ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
will try to incorporate that in this issue
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes I'll get rid of this part
_blogs/2015-02-10-hello-world.md
Outdated
@@ -0,0 +1,5 @@ | |||
--- | |||
title: Hello World |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this required for production?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
addressed in this questioned
_blogs/2015-02-15-example-1.md
Outdated
@@ -0,0 +1,6 @@ | |||
--- | |||
title: Example 1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this required for production?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will keep one example.md ( will get rid of the other twos) file to facilitate using markdown format for blogs( as all of the previous ones are HTML files). However setting published: false allows us to decide whether or not this will appear on website.
_data/links.yml
Outdated
links: | ||
- linkName: Booking.com dev blog | ||
url: https://blog.booking.com/ | ||
linkDesc: " " |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we avoid so many empty linkDesc ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some links contain text in addition to link-text ( like alongside giving codefoces link, we may want to specify "this is mostly used platform for cf" . "linkDesc" is included to give that flexibility.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
brings us to some sort of trade-off here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I personally vote for having "linkDesc"
link: https://www.linkedin.com/in/khandaker-mushfiqur-rahman-4a0593130/ | ||
- name: Abdullah Al Ishtiaq | ||
link: https://www.linkedin.com/in/abdullah-al-ishtiaq/ | ||
- name: Masum Rahman |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is anyone else missing ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes. will complete it later
_site/README.md
Outdated
@@ -0,0 +1,16 @@ | |||
# bsadd-home |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is more of a configuration question: Do we need to add _site folder to git ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Github builds jekyll itself ( tested that). Not sure whether we can get rid of _site folder altogether. Will let you know.
The website has been refactored into Jekyll with existing features. Data structures corresponding to Gallery, Member, Link, Activity, Blog have been added. I'll update the readme in anytime soon.
Please let me know anything missing.