Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactored the website into jekyll #9

Merged
merged 19 commits into from
May 21, 2020
Merged

Refactored the website into jekyll #9

merged 19 commits into from
May 21, 2020

Conversation

Masum95
Copy link
Contributor

@Masum95 Masum95 commented May 16, 2020

The website has been refactored into Jekyll with existing features. Data structures corresponding to Gallery, Member, Link, Activity, Blog have been added. I'll update the readme in anytime soon.
Please let me know anything missing.

Copy link
Member

@imranhasanhira imranhasanhira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just few things that came in quick look.

README.md Outdated
- if you have thumbnails for your pictures, put them inside img/timg folder with the same name as original image folder.
- insert necesary metadata in _data/gallery.yml file

(please note that if you don't have any thumbnails folder, you have to specify that in .yml by assigning empty string to thumbFolder variable i.e. `thumbFolder: ""` )
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we skip this step ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will try to incorporate that in this issue

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes I'll get rid of this part

@@ -0,0 +1,5 @@
---
title: Hello World
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this required for production?

Copy link
Contributor Author

@Masum95 Masum95 May 16, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

addressed in this questioned

@@ -0,0 +1,6 @@
---
title: Example 1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this required for production?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will keep one example.md ( will get rid of the other twos) file to facilitate using markdown format for blogs( as all of the previous ones are HTML files). However setting published: false allows us to decide whether or not this will appear on website.

_data/links.yml Outdated
links:
- linkName: Booking.com dev blog
url: https://blog.booking.com/
linkDesc: " "
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we avoid so many empty linkDesc ?

Copy link
Contributor Author

@Masum95 Masum95 May 16, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some links contain text in addition to link-text ( like alongside giving codefoces link, we may want to specify "this is mostly used platform for cf" . "linkDesc" is included to give that flexibility.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

brings us to some sort of trade-off here

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I personally vote for having "linkDesc"

link: https://www.linkedin.com/in/khandaker-mushfiqur-rahman-4a0593130/
- name: Abdullah Al Ishtiaq
link: https://www.linkedin.com/in/abdullah-al-ishtiaq/
- name: Masum Rahman
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is anyone else missing ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes. will complete it later

_site/README.md Outdated
@@ -0,0 +1,16 @@
# bsadd-home
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is more of a configuration question: Do we need to add _site folder to git ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Github builds jekyll itself ( tested that). Not sure whether we can get rid of _site folder altogether. Will let you know.

@github-pages github-pages bot temporarily deployed to github-pages May 19, 2020 11:01 Inactive
@github-pages github-pages bot temporarily deployed to github-pages May 19, 2020 11:14 Inactive
@github-pages github-pages bot temporarily deployed to github-pages May 19, 2020 11:55 Inactive
@github-pages github-pages bot temporarily deployed to github-pages May 19, 2020 12:00 Inactive
@github-pages github-pages bot temporarily deployed to github-pages May 19, 2020 12:03 Inactive
@github-pages github-pages bot temporarily deployed to github-pages May 19, 2020 12:11 Inactive
@github-pages github-pages bot temporarily deployed to github-pages May 19, 2020 12:11 Inactive
@github-pages github-pages bot temporarily deployed to github-pages May 19, 2020 13:37 Inactive
@imranhasanhira imranhasanhira merged commit e64edb8 into master May 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants