Skip to content

Feat rule platform modulename #79

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 56 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
56 commits
Select commit Hold shift + click to select a range
3d629db
chore(all): add package-lock.json to .gitignore
Jul 17, 2019
10d9a25
chore(prettier): add prettier
Jul 17, 2019
4c88444
chore(babel): extract config out of package.json into .babelrc
Jul 17, 2019
25793a5
chore(mocha): use test/mocha.opts file to specify babel loading
Jul 17, 2019
b17582d
feat(rule): add rule for webpack-entry-point
Jul 17, 2019
160583d
refactor(rule/webpack-entry-point): use embedFilenameInCode
Jul 18, 2019
08c5e00
refactor(rule/webpack-entry-point): use moduleExportsAsFunction
Jul 18, 2019
c6b7e31
fix(rule/webpack-entry-point): checks entry.app is 'aurelia-bootstrap…
Jul 18, 2019
e35bd32
feat(rule/webpack-entry-point): checks arrow functions
Jul 18, 2019
06d62fe
refactor(rule/webpack-entry-point): extract eslint-types.js
Jul 18, 2019
6946f29
feat(rule/platform-modulename): check use.globalResources
Jul 18, 2019
e97a30e
test(rule/platform-module): multi-length arrays
Jul 18, 2019
0d00283
test(rule/platform-module): allow non-array usage
Jul 18, 2019
d6ce01b
test(rule/platform-module): feature modules are not checked
Jul 18, 2019
2ef5caf
refactor(rule/platform-modulename): separate into multiple test files
Jul 18, 2019
55da553
refactor(rule/platform-modulename): inline methods
Jul 18, 2019
d2a7358
test(rule/platform-modulename): check setRoot
Jul 18, 2019
3499568
test(rule/platform-modulename): check setRoot
Jul 18, 2019
e6d657c
fix(rule/platform-modulename): set description
Jul 18, 2019
2762960
fix(rule/platform-modulename): fixable
Jul 18, 2019
6407fe9
feat(rule/platform-modulename): add optional debug property to rule
Jul 18, 2019
88334e2
fix(rule/platform-modulename): checks aurelia is used before enabling…
Jul 18, 2019
9787232
Merge branch 'chore-prettier' into develop
Jul 19, 2019
079cc21
Merge branch 'chore-mocha' into develop
Jul 19, 2019
16a8c20
Merge branch 'chore-package-lock' into develop
Jul 19, 2019
c3fa1e8
Merge branch 'feat-rule-webpack-entry-point' into develop
Jul 19, 2019
7bbc082
Merge branch 'feat-rule-platform-modulename' into develop
Jul 19, 2019
c2ba3f9
fix(rule/platform-modulename): remove debug from test
Jul 19, 2019
75034bb
fix(rule/platform-modulename): featureModule should not enforce checks
Jul 19, 2019
3cad898
fix(rule/platform-modulename): change to spread arguments in console.log
Jul 19, 2019
6a4229d
Merge branch 'feat-rule-platform-modulename' into develop
Jul 19, 2019
01a606c
refactor(rule/platform-modulename): include method name in debugs
Jul 19, 2019
b05bcf3
Merge branch 'feat-rule-platform-modulename' into develop
Jul 19, 2019
e6aa966
refactor(rule/platform-modulename): add debug options to setRoot test
Jul 19, 2019
172d203
Merge branch 'feat-rule-platform-modulename' into develop
Jul 19, 2019
a27e315
fix(rule/platform-modulename): remove hard coding of debug in test
Jul 19, 2019
f064b28
Merge branch 'feat-rule-platform-modulename' into develop
Jul 19, 2019
2a9e07a
refactor(rule/platform-modulename): exit early after checking setRoot.
Jul 19, 2019
4e41f44
feat(rule/platform-modulename): check use.feature()
Jul 19, 2019
70997fd
Merge branch 'feat-rule-platform-modulename' into develop
Jul 19, 2019
9922b2d
feat(rule/platform-modulename): check use.plugin()
Jul 19, 2019
5012596
Merge branch 'feat-rule-platform-modulename' into develop
Jul 19, 2019
fb87bd2
fix(rule/platform-modulename): remove hard coding of debug in test
Jul 19, 2019
443e48a
refactor(rule/platform-modulename): remove excessive log debugging
Jul 19, 2019
ddd9463
feat(rule/platform-modulename): check router config
Jul 19, 2019
66c5d62
Merge branch 'feat-rule-platform-modulename' into develop
Jul 19, 2019
1d515a3
refactor(rule/platform-modulename): to use checkArgumentsWrappedInPla…
Jul 19, 2019
d1fa969
Merge branch 'develop' into feat-rule-platform-modulename
Jul 19, 2019
a22e7d8
refactor(rule/platform-modulename): checkArgumentsWrappedInPlatformMo…
Jul 19, 2019
b4e2baa
fix(rule/platform-modulename): incorrect default argument destructuring
Jul 19, 2019
eeafdc4
feat(rule/platform-modulename): add fix for PLATFORM.moduleName
Jul 19, 2019
0b9e1b8
style(rules): fix eslint error
Jul 22, 2019
dfb400f
fix(rules): add new rules to src/index.js
Jul 22, 2019
1a9aa8c
fix(rules/webpack-entry-point): error messages to be more eslint like
Jul 22, 2019
6601cd9
style(rules): disable array-bracket-spacing to problem line
Jul 22, 2019
1010abb
fix(rules/platform-modulename): check for undefined property
Jul 22, 2019
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .babelrc
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
{
presets: ['stage-1', 'es2015']
}
1 change: 1 addition & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -2,3 +2,4 @@ dist/
node_modules/
npm-debug.log
coverage/
package-lock.json
34 changes: 34 additions & 0 deletions .prettierignore
Original file line number Diff line number Diff line change
@@ -0,0 +1,34 @@
*.min.js
**/node_modules/**
flow-typed

# webfont demo styles
**/specimen_files

# built sites
benchmarks/**/public
e2e-tests/**/public
examples/**/public
integration-tests/**/public
www/public

# cache-dirs
**/.cache

# ignore built packages
packages/**/*.js
!packages/gatsby/cache-dir/**/*.js
!packages/*/src/**/*.js
packages/gatsby/cache-dir/commonjs/**/*.js

# fixtures
**/__testfixtures__/**
**/__tests__/fixtures/**

infrastructure

# coverage
coverage

# forestry files
.forestry/**/*
19 changes: 19 additions & 0 deletions .prettierrc.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
module.exports = {
endOfLine: 'lf',
semi: true,
singleQuote: true,
useTabs: true,
trailingComma: 'es5',
overrides: [
{
// This file uses semicolons. It's needed here because `documentation`
// package (used to parse jsdoc and provide content for API reference pages)
// behaviour is inconsistent when not using semicolons after
// object declarations.
files: ['**/api-node-helpers-docs.js'],
options: {
semi: true,
},
},
],
}
15 changes: 6 additions & 9 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -24,25 +24,28 @@
],
"scripts": {
"build": "npm run lint && npm run test && rm -rf dist && babel src --out-dir dist",
"test": "babel-node node_modules/.bin/isparta cover --report text-summary --report lcov node_modules/mocha/bin/_mocha -- --recursive",
"test": "node node_modules/isparta/bin/isparta cover --report text-summary --report lcov node_modules/mocha/bin/_mocha -- --recursive",
"lint": "eslint src/ test/",
"ci": "npm run build && cat coverage/lcov.info | node_modules/.bin/coveralls",
"patch": "release patch",
"minor": "release minor",
"major": "release major"
},
"dependencies": {
"eslint-plugin-sort-class-members": "^1.0.1"
"eslint-plugin-sort-class-members": "^1.0.1",
"prettier": "^1.18.2"
},
"peerDependencies": {
"eslint": ">=0.8.0"
},
"devDependencies": {
"@bryanrsmith/eslint-config-standard": "^2.1.3",
"babel-cli": "^6.9.0",
"babel-core": "^6.26.3",
"babel-eslint": "^6.0.4",
"babel-preset-es2015": "^6.9.0",
"babel-preset-stage-1": "^6.5.0",
"babel-register": "^6.26.0",
"coveralls": "^2.11.9",
"eslint": "^2.13.0",
"isparta": "^4.0.0",
Expand All @@ -52,11 +55,5 @@
"engines": {
"node": ">=4.0.0"
},
"license": "MIT",
"babel": {
"presets": [
"stage-1",
"es2015"
]
}
"license": "MIT"
}
6 changes: 6 additions & 0 deletions src/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -2,17 +2,21 @@ import injectRule from './rules/inject-matches-ctor';
import injectTypeRule from './rules/inject-type';
import noConventionsRule from './rules/no-conventions';
import noConsoleLogRule from './rules/no-console-log';
import platformModulename from './rules/platform-modulename';
import storeUnsubscribeRule from './rules/store-unsubscribe';
import sortClassMembers, { defaultOrder } from './rules/sort-class-members';
import webpackEntryPoint from './rules/webpack-entry-point';

module.exports = {
rules: {
'inject-matches-ctor': injectRule,
'inject-type': injectTypeRule,
'no-conventions': noConventionsRule,
'no-console-log': noConsoleLogRule,
'platform-modulename': platformModulename,
'store-unsubscribe': storeUnsubscribeRule,
'sort-class-members': sortClassMembers,
'webpack-entry-point': webpackEntryPoint,
},
configs: {
recommended: {
Expand All @@ -21,10 +25,12 @@ module.exports = {
'inject-type': 0,
'no-conventions': 0,
'no-console-log': 0,
'platform-modulename': 0,
'store-unsubscribe': 2,
'sort-class-members': [ 2, {
order: defaultOrder,
}],
'webpack-entry-point': 0,
},
},
},
Expand Down
20 changes: 20 additions & 0 deletions src/rules/eslint-types.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
module.exports = {
types: {
ArrayExpression: 'ArrayExpression',
ArrowFunctionExpression: 'ArrowFunctionExpression',
AssignmentExpression: 'AssignmentExpression',
BlockStatement: 'BlockStatement',
CallExpression: 'CallExpression',
ExpressionStatement: 'ExpressionStatement',
FunctionDeclaration: 'FunctionDeclaration',
FunctionExpression: 'FunctionExpression',
Identifier: 'Identifier',
Literal: 'Literal',
MemberExpression: 'MemberExpression',
MethodDefinition: 'MethodDefinition',
ObjectExpression: 'ObjectExpression',
Program: 'Program',
Property: 'Property',
ReturnStatement: 'ReturnStatement',
},
};
Loading