feat(language_service): Allow users to add custom css custom data #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
crt:csslsrs
CodSpeed Performance ReportMerging #8 will not alter performanceComparing Summary
|
goulvenclech
approved these changes
Dec 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
Update language service to take a vec of custom data instead of a defined one. WASM doesn't have access to this yet, but this PR also prepares for that eventually.
This PR also includes a refactors to the document handling inside of the document store, following previous work I'd done in https://github.com/web-lsp/csslsrs/pull/6 for perf reasons
How is it tested?
Tests should still pass, updated ones that needed to use new options
How is it documented?
Updated docs for affected methods